Revert "[null-safety] reland: migrate app side flutter driver to null-safety" #67561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
a: accessibility
jason-simmons
approved these changes
Oct 7, 2020
liyuqian
approved these changes
Oct 7, 2020
Contributor
|
LGTM The lack of any flutter web driver test coverage in the tree should remain a P1, as this will block any null safe benchmarks. @pcsosinski @leafpetersen |
Contributor
Author
|
I'm going to land this without waiting for CI on red to try to help get the tree(s) back to green faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #67441
Fixes #67560