Skip to content

[flutter_releases] Flutter 1.22.1 Framework Cherrypicks #67552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
christopherfujino merged 5 commits into from
Oct 8, 2020
Merged

[flutter_releases] Flutter 1.22.1 Framework Cherrypicks #67552

christopherfujino merged 5 commits into from
Oct 8, 2020

Conversation

@christopherfujino
Copy link
Contributor

@christopherfujino christopherfujino commented Oct 7, 2020 •
edited
Loading

Scheduled Cherrypicks

@willlarche @christopherfujino
[Docs] [Material] Fix Icons api docs (flutter#66508)
32776f6 
* [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs.

* Better documentation and that special awful case.

* Couple more places to remove.
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 7, 2020

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. labels Oct 7, 2020
@google-cla google-cla bot added the cla: yes label Oct 7, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 7, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@christopherfujino christopherfujino changed the title [flutter_releases] [flutter_releases] Flutter 1.20.1 Engine Cherrypicks Oct 7, 2020
@christopherfujino christopherfujino changed the title [flutter_releases] Flutter 1.20.1 Engine Cherrypicks [flutter_releases] Flutter 1.20.1 Framework Cherrypicks Oct 7, 2020
@jonahwilliams
Copy link
Contributor

jonahwilliams commented Oct 7, 2020

Missing #66962

@christopherfujino christopherfujino marked this pull request as draft October 7, 2020 19:56
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Oct 7, 2020

Missing #66962

Yeah, I shouldn't have added reviewers yet, this is still WIP

@christopherfujino christopherfujino changed the title [flutter_releases] Flutter 1.20.1 Framework Cherrypicks [flutter_releases] Flutter 1.22.1 Framework Cherrypicks Oct 7, 2020
pedromassango and others added 2 commits October 7, 2020 13:52
@pedromassango @christopherfujino
Add back the autovalidate class property (flutter#66267)
7dd38dd 
* Add back autovalidate property

* Add autovalidate property back (include tests)

* Fix typos

* One more test :)
@christopherfujino
[flutter_tools] prevent running analyze-size with split-debug-info (f…
705d826 
…lutter#66983)

Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags.

Fixes flutter#66962
@google-cla
Copy link

google-cla bot commented Oct 7, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 7, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Oct 7, 2020
@christopherfujino
Copy link
Contributor Author

christopherfujino commented Oct 7, 2020

I manually updated the cla-bot label because the contributor in question has already signed the CLA.

@google-cla
Copy link

google-cla bot commented Oct 7, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Oct 7, 2020
@google-cla
Copy link

google-cla bot commented Oct 8, 2020

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Oct 8, 2020
@christopherfujino christopherfujino marked this pull request as ready for review October 8, 2020 00:09
pcsosinski
pcsosinski approved these changes Oct 8, 2020
View reviewed changes
Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved for branch

jonahwilliams
jonahwilliams approved these changes Oct 8, 2020
View reviewed changes
Copy link
Contributor

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tools change

@christopherfujino christopherfujino merged commit f30b7f4 into flutter:flutter-1.22-candidate.12 Oct 8, 2020
@christopherfujino christopherfujino deleted the flutter-1.22-candidate.12 branch October 8, 2020 17:06
@pedromassangocode pedromassangocode mentioned this pull request Oct 12, 2020
Closed
@christopherfujino christopherfujino mentioned this pull request Oct 15, 2020
Merged
willlockwood pushed a commit to willlockwood/flutter that referenced this pull request Dec 25, 2020
@christopherfujino @willlarche
@pedromassango @willlockwood
[flutter_releases] Flutter 1.22.1 Framework Cherrypicks (flutter#67552)
7bdd5a4 
* [Docs] [Material] Fix Icons api docs (flutter#66508)

* [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs.

* Better documentation and that special awful case.

* Couple more places to remove.

* Add back the autovalidate class property (flutter#66267)

* Add back autovalidate property

* Add autovalidate property back (include tests)

* Fix typos

* One more test :)

* [flutter_tools] prevent running analyze-size with split-debug-info (flutter#66983)

Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags.

Fixes flutter#66962

* fix invocatiion of non-existent function after cherry pick

* update engine revision

Co-authored-by: Will Larche <[email protected]>
Co-authored-by: Pedro Massango <[email protected]>
Co-authored-by: Jonah Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedromassangocode pedromassangocode Awaiting requested review from pedromassangocode

3 more reviewers

@willlarche willlarche willlarche approved these changes

@jonahwilliams jonahwilliams jonahwilliams approved these changes

@pcsosinski pcsosinski pcsosinski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@christopherfujino @jonahwilliams @willlarche @pcsosinski @pedromassango