Remove required for onRemove in InteractiveInkFeature.create#67427
Merged
goderbauer merged 1 commit intoflutter:masterfrom Oct 6, 2020
Merged
Remove required for onRemove in InteractiveInkFeature.create#67427goderbauer merged 1 commit intoflutter:masterfrom
goderbauer merged 1 commit intoflutter:masterfrom
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
commented
Oct 6, 2020
| BorderRadius? borderRadius, | ||
| ShapeBorder? customBorder, | ||
| double? radius, | ||
| required VoidCallback? onRemoved, |
Member
Author
There was a problem hiding this comment.
@a14n Can you confirm that there was no reason for adding the required here in the first place?
Member
Author
13 tasks
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
Member
Author
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I believe this was accidentally added in https://github.com/flutter/flutter/pull/67166/files#r500450922, but there is no reason for this parameter to be required. In fact, none of the subclasses mark it as required either.
Removing, since it is failing tests in google.
Related Issues
n/a
Tests
I added the following tests:
n/a
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.