Conversation
flutter-dashboard
bot
added
a: tests
|
@a14n is this the last PR for Material, so that when this lands all of Material supports null safety? |
Yes after this PR the Flutter framework will be migrated to null safety. |
| ..curve = null | ||
| ..reverseCurve = null; | ||
| if (newValue) | ||
| position.reverseCurve = null; |
There was a problem hiding this comment.
cc @HansMuller we might be able to get rid of this line too, it looks like RenderToggleable always sets reverseCurve when it sets curve. But that's a story for another PR.
| BorderRadius? borderRadius, | ||
| ShapeBorder? customBorder, | ||
| double? radius, | ||
| required VoidCallback? onRemoved, |
There was a problem hiding this comment.
Tests in google are breaking because this was marked required.
@a14n do you remember why this needs to be required now?
/cc @Hixie @HansMuller
There was a problem hiding this comment.
Nothing obvious comes to my mind. We can remove the required keyword.
6 participants
Description
NNBD migration for material
Related Issues
Tests
I added the following tests:
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.