Skip to content

docs for image disposal #67066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dnfield merged 1 commit into from
Oct 1, 2020
Merged

docs for image disposal #67066

dnfield merged 1 commit into from
Oct 1, 2020

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Oct 1, 2020 •
edited
Loading

Follow-up on some post-submit review comments from @goderbauer on #66688

No tests since this is a documentation only change.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Oct 1, 2020
@flutter-dashboard
Copy link

flutter-dashboard bot commented Oct 1, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@dnfield dnfield requested a review from goderbauer October 1, 2020 17:19
goderbauer
goderbauer approved these changes Oct 1, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you!

@dnfield dnfield added d: api docs Issues with https://api.flutter.dev/ waiting for tree to go green labels Oct 1, 2020
@fluttergithubbot
Copy link
Contributor

fluttergithubbot commented Oct 1, 2020

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux web_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.

@dnfield
Copy link
Contributor Author

dnfield commented Oct 1, 2020

I'm going to land this ignoring the web flake. I posted about it in the infra chat.

@dnfield dnfield merged commit bcb2ac5 into flutter:master Oct 1, 2020
@dnfield dnfield deleted the image_dispose_better branch October 1, 2020 21:14
dnfield added a commit to dnfield/flutter that referenced this pull request Oct 1, 2020
@dnfield
Revert "docs for image disposal (flutter#67066)"
449fcc9 
This reverts commit bcb2ac5.
@dnfield dnfield mentioned this pull request Oct 1, 2020
Merged
dnfield added a commit that referenced this pull request Oct 1, 2020
@dnfield
Revert dispose images when done (#67100)
473358d 
* Revert "docs for image disposal (#67066)"

This reverts commit bcb2ac5.

* Revert "Dispose of images after using them (#66688)"

This reverts commit a795469.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

d: api docs Issues with https://api.flutter.dev/ framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @fluttergithubbot @goderbauer @googlebot