Skip to content

test that ensureVisible does not change PageView pages #67021

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Oct 1, 2020
Merged

test that ensureVisible does not change PageView pages #67021

fluttergithubbot merged 1 commit into from
Oct 1, 2020

Conversation

@dnfield
Copy link
Contributor

@dnfield dnfield commented Sep 30, 2020

Creates a test that would have caught the regression in #65226

Should help reland that for #65100

See also #66918

/cc @xu-baolin

@dnfield dnfield requested a review from goderbauer September 30, 2020 23:45
@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 30, 2020
@dnfield dnfield changed the title test test that ensureVisible does not change PageView pages Sep 30, 2020
goderbauer
goderbauer approved these changes Sep 30, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fluttergithubbot fluttergithubbot merged commit 25f44bb into flutter:master Oct 1, 2020
@dnfield dnfield deleted the test_for_ensure_vis branch October 1, 2020 03:21
@dnfield dnfield mentioned this pull request Oct 9, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dnfield @goderbauer @googlebot @fluttergithubbot