[flutter_tools] hot reload/restart update for asset manager change #66742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
tool
jonahwilliams
commented
Sep 26, 2020
| if (content.isModified || (bundleFirstUpload && archivePath != null)) { | ||
| // Only update assets if they have been modified. | ||
| if (content.isModified) { | ||
| final Uri deviceUri = _fileSystem.path.toUri(_fileSystem.path.join(assetDirectory, archivePath)); |
Contributor
Author
There was a problem hiding this comment.
bonus perf improvement by moving this under the check
…er into try_different_reload
Contributor
|
This pull request is not suitable for automatic merging in its current state.
|
…er into try_different_reload
added 3 commits
October 9, 2020 09:14
jonahwilliams
commented
Oct 9, 2020
| String dillOutputPath, | ||
| bool fullRestart = false, | ||
| String projectRootPath, | ||
| bool skipAssets = false, |
zanderso
approved these changes
Oct 9, 2020
| // Only update assets if they have been modified, or if this is the | ||
| // first upload of the asset bundle. | ||
| if (content.isModified || (bundleFirstUpload && archivePath != null)) { | ||
| if (content.isModified && !bundleFirstUpload) { |
Member
There was a problem hiding this comment.
nit: flip the sense and unindent
if (!content.isModified || bundleFirstUpload) {
return;
}
...
Contributor
|
LGTM as well. |
Contributor
Author
|
Google testing passed |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not upload all assets on initial devFS sync. This should increase the reliability of the initial connection, even in the face of flaky devfs behavior, in addition to a moderate perf improvement.
Updates fast-start to build assets as part of the initial bundle
Requires flutter/engine#21436
Requires flutter/engine#21586
Requires flutter/engine#21611