[Docs] [Material] Fix Icons api docs #66508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs.
flutter-dashboard
bot
added
f: material design
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
willlarche
changed the title
JoseAlba
approved these changes
Sep 24, 2020
Contributor
JoseAlba
left a comment
JoseAlba
left a comment
There was a problem hiding this comment.
██╗ ██████╗ ████████╗███╗ ███╗
██║ ██╔════╝ ╚══██╔══╝████╗ ████║
██║ ██║ ███╗ ██║ ██╔████╔██║
██║ ██║ ██║ ██║ ██║╚██╔╝██║
███████╗╚██████╔╝ ██║ ██║ ╚═╝ ██║
╚══════╝ ╚═════╝ ╚═╝ ╚═╝ ╚═╝
rami-a
approved these changes
Sep 24, 2020
|
removing CP label from PR in favor of issue (#66407) |
christopherfujino
pushed a commit
to chris-forks/flutter
that referenced
this pull request
Oct 7, 2020
* [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs. * Better documentation and that special awful case. * Couple more places to remove.
christopherfujino
added a commit
that referenced
this pull request
Oct 8, 2020
* [Docs] [Material] Fix Icons api docs (#66508) * [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs. * Better documentation and that special awful case. * Couple more places to remove. * Add back the autovalidate class property (#66267) * Add back autovalidate property * Add autovalidate property back (include tests) * Fix typos * One more test :) * [flutter_tools] prevent running analyze-size with split-debug-info (#66983) Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags. Fixes #66962 * fix invocatiion of non-existent function after cherry pick * update engine revision Co-authored-by: Will Larche <[email protected]> Co-authored-by: Pedro Massango <[email protected]> Co-authored-by: Jonah Williams <[email protected]>
willlockwood
pushed a commit
to willlockwood/flutter
that referenced
this pull request
Dec 25, 2020
* [Docs] [Material] Fix Icons api docs (flutter#66508) * [Docs] [Icons] Updating dart doc styles to recognize more styles of icons. All the 4 icon styles we support have to be pulled from 4 individual web fonts when we show the html page for api docs. * Better documentation and that special awful case. * Couple more places to remove. * Add back the autovalidate class property (flutter#66267) * Add back autovalidate property * Add autovalidate property back (include tests) * Fix typos * One more test :) * [flutter_tools] prevent running analyze-size with split-debug-info (flutter#66983) Running a build command with split debug info and analyze size causes a crash in the snapshot analysis library. Disable the combination of these two flags. Fixes flutter#66962 * fix invocatiion of non-existent function after cherry pick * update engine revision Co-authored-by: Will Larche <[email protected]> Co-authored-by: Pedro Massango <[email protected]> Co-authored-by: Jonah Williams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The update to icons #61778 introduced a bug in the generated api doc.
This fixes the script so it uses the correct web font for the new icon styles and it updates the styling of the dart doc both to support the new classes and to remove unused styles.
Since the keys for the web font included the styling suffix, there was whitespace after the icon. That's been fixed.
Before:
After:
Related Issues
Closes #66407
Tests
I added the following tests:
I added no tests. I don't think we have those for the api doc site.
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.