-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Re-land ScaffoldMessenger #66504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Re-land ScaffoldMessenger #66504
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
d608e4a
ScaffoldMessenger
Piinks 8f7593c
Remove unintended changes
Piinks 6e784ab
Fix sample
Piinks 20d8afd
++
Piinks d9f57e3
Apply suggestions from code review
Piinks 063e159
Update docs
Piinks c4632bd
Review feedback
Piinks 843e287
Sample app
Piinks 2042863
Merge branch 'master' of github.com:flutter/flutter into scaffoldMess…
Piinks e3cd0d7
Fix sample code
Piinks 72469cd
Review feedback
Piinks 3626dc3
Merge branch 'master' of github.com:flutter/flutter into scaffoldMess…
Piinks c04ffa1
Update to re-land
Piinks a475e3f
More test
Piinks 0c1373b
Fix analyzer for deprecation.
Piinks 30981fc
Review feedback
Piinks a667729
Analyzer
Piinks 739b0e2
Re-trigger build
Piinks ac6a955
++
Piinks 3117436
Merge branch 'master' of github.com:flutter/flutter into scaffoldMess…
Piinks 587dc5b
Analyzer again
Piinks 43bd2ea
Re-work for untouched SnackBar classes
Piinks aa1d646
Tidying
Piinks c552f47
Add nullOk for .of, + tests
Piinks df692db
Analyzer
Piinks 5216711
Merge branch 'master' of github.com:flutter/flutter into scaffoldMess…
Piinks ef5d262
Merge branch 'master' of github.com:flutter/flutter into scaffoldMess…
Piinks 6ce0413
Update packages/flutter/lib/src/material/scaffold.dart
Piinks File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't the
ofcall return null if there's no messenger in the tree?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can, but in this case it there is a MaterialApp above in the sample code, so it has a ScaffoldMessenger by default.