-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Stream logging from attached debugger on iOS 13+ #66399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
approved these changes
Sep 22, 2020
Contributor
jonahwilliams
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ship it
Member
Author
|
There are three commits in this PR:
|
Contributor
|
If A, B, and C work then they should all work together too :) |
c409a66 to
b6a584b
Compare
This was referenced Sep 23, 2020
This was referenced Oct 9, 2020
2 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: contributor-productivity
Team-specific productivity, code health, technical debt.
platform-ios
iOS applications specifically
tool
Affects the "flutter" command-line tool. See also t: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland #66092. See #66364 (comment) for details.
Additionally, the debugger will only attach on iOS 13+ where the syslog trick doesn't work anymore.
Also, this includes #66293 to make the integration test an atomic addition to this feature.
Description
As of iOS 13, the host can't directly read the device logs from the host. #43915 connected to the VM observatory and read the log lines from the logging services.
On
flutter runandflutter drive(notattachin this PR), instead of waiting to attach to the observatory, instead launch the app with the debugger and stay attached to stream in the logs fromlldb. See #54781 (comment) for details. This should also reduce devicelab flakes.This will give the tool access to:
print()stderr.writeln, other I/O sinksos_log,assertsetc)Notes
flutter attach. A follow up PR could attach the debugger in that scenario as well (without re-launching), and then the VM connection can be removed.idevicesyslog.Related Issues
Fixes #44717
Fixes #44718
Fixes #54781
#39240 (fixes
run/drive, notattach)#58078 (fixes
run/drive, notattach)Mitigate #46705 (
run/drive, notattach)Will allow us to turn off mDNS fallback for
driveon CI to solve iOS 14 issue #65207Note to self: check if this fixes #19196
Tests
Follow up with logging integration tests so this stops regressing.
Also, manually tested:
ios-deployprocesses aren't leakingChecklist
///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change