Skip to content

Conversation

@abarth
Copy link
Contributor

@abarth abarth commented Nov 1, 2016

Fixes #6417

@abarth
Copy link
Contributor Author

abarth commented Nov 1, 2016

@danrubel @Hixie

Copy link
Contributor

@danrubel danrubel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question

<component name="NewModuleRootManager" inherit-compiler-output="true">
<exclude-output />
<content url="file://$MODULE_DIR$">
<excludeFolder url="file://$MODULE_DIR$/.pub" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think .pub is an implementation detail for both pub and flutter packages and should be excluded.
@devoncarew might know for sure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry. This is just intellij fighting itself.

@abarth abarth merged commit 67f5910 into flutter:master Nov 1, 2016
@abarth abarth deleted the packages_get branch November 1, 2016 20:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update all tool string containing 'pub get' to 'flutter packages get'

2 participants