Skip to content

Conversation

@goderbauer
Copy link
Member

@goderbauer goderbauer commented Sep 15, 2020

Description

Fixes flutter_gallery_sksl_warmup__transition_perf_e2e.

Related Issues

#65528

Tests

I added the following tests:

Fixes existing test.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard
Copy link

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the framework flutter/packages/flutter repository. See also f: labels. label Sep 15, 2020
@goderbauer goderbauer requested a review from a14n September 15, 2020 16:22
@goderbauer goderbauer changed the title Fix tree Fixes flutter_gallery_sksl_warmup__transition_perf_e2e after NNBD migration Sep 15, 2020
@goderbauer
Copy link
Member Author

Superseded by #65861.

@goderbauer goderbauer closed this Sep 15, 2020
@goderbauer goderbauer deleted the fixtree branch November 11, 2020 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants