Skip to content

Conversation

@goderbauer
Copy link
Member

Reverts #64672

/cc @a14n @Hixie

See #64672 for failures caused by this.

@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels. labels Sep 9, 2020
Copy link
Contributor

@a14n a14n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😢

@zanderso
Copy link
Member

zanderso commented Sep 9, 2020

See also failures in flutter_gallery_sksl_warmup__transition_perf_e2e in the device lab.

@zanderso
Copy link
Member

zanderso commented Sep 9, 2020

Landing revert on red.

@zanderso zanderso merged commit 127e679 into master Sep 9, 2020
@zanderso zanderso deleted the revert-64672-nnbd-widgets branch September 9, 2020 22:18
@a14n
Copy link
Contributor

a14n commented Sep 10, 2020

See also failures in flutter_gallery_sksl_warmup__transition_perf_e2e in the device lab.

Unfortunately I cannot sign in into https://flutter-dashboard.appspot.com/#/build to see what happened.

Moreover I really don't know who is the best person to help to fix it (it looks related to AOT compiler and nullsafety). Do you have someone in mind?

@a14n a14n mentioned this pull request Sep 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) f: cupertino flutter/packages/flutter/cupertino repository framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants