Remove flutter_gallery_ios32__transition_perf test #65415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes flutter#60559 flutter_gallery__transition_perf_e2e_ios32 will be replacing this flaky test and all performance metrics are quite close: https://flutter-flutter-perf.skia.org/e/?queries=test%3Dflutter_gallery__transition_perf_e2e_ios32%26test%3Dflutter_gallery_ios32__transition_perf In the future, one can also compare the historical performance trend by adding those two tests in the same plot.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
flutter-dashboard
bot
added
the
c: contributor-productivity
tvolkert
approved these changes
Sep 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #60559
flutter_gallery__transition_perf_e2e_ios32 will be replacing this flaky
test and all performance metrics are quite close:
https://flutter-flutter-perf.skia.org/e/?queries=test%3Dflutter_gallery__transition_perf_e2e_ios32%26test%3Dflutter_gallery_ios32__transition_perf
In the future, one can also compare the historical performance trend by
adding those two tests in the same plot.