Handle lifecycle and navigation platform messages #6524
Conversation
Soon the engine will send this information through platform messages.
abarth
force-pushed
the
navigation_lifecycle
branch
from
a87937c to
aca122e
Compare
|
|
Maybe we should make our own mojo called juju. :) I'm open to suggestions about how to approach this problem. |
|
Yeah I don't have a better suggestion. Mojo solved this problem my code-generating parsers that enforced type correctness. That seems like overkill here. |
|
Yes! JSON for platform/language interoperability was making me super uncomfortable as well. I didn’t think that decision was open for debate. I do agree Mojo was overkill for our needs. And it was trying to solve for a different and/or broader use-case. The JSON approach is easier in its implementation but hardly less error prone or verbose. How about a dead simple IDL that can deal with basic types and collections (we don’t even need to deal with object graphs)? It can generate stubs for various languages that we fill in. Isn’t that all we need? We will have to manage threading and serialization/deserialization of arguments and return types. But it should make for a safer and less verbose scheme. I would love to take a stab at such a scheme. Though I do understand if we want to stick with what we have got. Its ugly but there is no doubt it works. Chinmay
|
|
All decisions are open for debate. |
* Add support for shadows in text. * Use dart:ui Shadow as base class for Shadows * Update lerp definition * Roll engine 3ffa362..84fe4a9 - Text Shadows and update goldens for skia roll. git log 50c2e69..32f417d --oneline --no-merges 32f417d Roll tonic to 077be256142ede39a271385907faadf4fcc62a4d. (#6541) 4ee7725 Revert "Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)" (#6537) 964acaf Roll src/third_party/skia 646d917d3c71..c6a17104ad68 (1 commits) (#6536) d4bae4c Roll src/third_party/skia 2b2c00f6ec36..646d917d3c71 (1 commits) (#6535) ff93ccf Roll src/third_party/skia 681692726fc0..2b2c00f6ec36 (1 commits) (#6534) a4161c8 Roll src/third_party/skia 23775a2e9736..681692726fc0 (1 commits) (#6532) 116072e Roll src/third_party/skia 7435f2553f53..23775a2e9736 (1 commits) (#6531) ef0b0f6 Roll src/third_party/skia bc7a51e79c5b..7435f2553f53 (1 commits) (#6530) f46b7b9 Roll src/third_party/skia b28db529c866..bc7a51e79c5b (1 commits) (#6529) 9033c39 Roll src/third_party/skia 7e67041a1428..b28db529c866 (1 commits) (#6528) e6887a4 Add missing imports for unicode/utf16.h (#6524) 1242f6d Roll src/third_party/skia d38382d060ca..7e67041a1428 (2 commits) (#6527) a1bbea7 Add a no-op platform view layer. (#6505) 2bb3afa Roll src/third_party/skia 21bd60daa3f3..d38382d060ca (10 commits) (#6526) 75e8752 Fix the Mac embedder build (#6525) 436f970 Add version check for dismissable (#6522) 7767c78 Provide a default GL function resolver in the embedder (#6523) 32841dd Case-insensitive matching of family names for custom fonts (#6519) a9076c7 Roll src/third_party/skia 419709dbb167..21bd60daa3f3 (11 commits) (#6520) f2e7441 An API for loading fonts from a buffer provided by the application (#6508) 05aac0f fix ResourceExtractor npe. (#6461) cf5a2a1 Roll src/third_party/skia b27a9cf2f4a8..419709dbb167 (16 commits) (#6517) 84fe4a9 Re-revert invalid line height tests (#6516) 5f52956 Add support for text shadows (#6385) e44c10c Reland "Share engine layers with the framework" (#6412) (#6468) ba04499 Roll Dart to 1f4dfce179c8f05c9e48759300a15e671b88cc10 (#6515)
3 participants
Soon the engine will send this information through platform messages.