Skip to content

Conversation

@abrush21
Copy link
Contributor

@abrush21 abrush21 commented Sep 3, 2020

This change disables a failing test prevent engine PR flutter/engine#20385 from merging.

Description

PR flutter/engine#20385 failed to merge because of a failure in matchers_test.dart. This change disables the failing test to enable that merge.

Related Issues

flutter/engine#20385

Tests

N/A

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels. labels Sep 3, 2020
@HansMuller HansMuller requested a review from chunhtai September 3, 2020 23:37
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you may need to rebase off master again to fix the failing test

This change disables a failing test prevent PR flutter#20385 from merging.
@chunhtai chunhtai merged commit 68660e1 into flutter:master Sep 10, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: tests "flutter test", flutter_test, or one of our tests framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants