Skip to content

Revert "Roll Engine from 165abef0a2cb to e979c29a2a50 (42 revisions)" #65188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Sep 3, 2020
Merged

Revert "Roll Engine from 165abef0a2cb to e979c29a2a50 (42 revisions)" #65188

jonahwilliams merged 1 commit into from
Sep 3, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Sep 3, 2020 •
edited
Loading

Reverts #65178

This is causing the android hybrid views test to fail with numerous GL errors:

2020-09-03T10:28:38.615987: stdout: [   +1 ms] E/flutter (11984): [ERROR:flutter/shell/platform/android/android_context_gl.cc(124)] Could not make the context current
2020-09-03T10:28:38.616421: stdout: [        ] E/flutter (11984): [ERROR:flutter/shell/platform/android/android_context_gl.cc(53)] EGL Error: EGL_BAD_ACCESS (12290)
2020-09-03T10:28:38.616513: stdout: [        ] E/flutter (11984): [ERROR:flutter/shell/gpu/gpu_surface_gl.cc(242)] Could not make the context current to acquire the frame.

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Sep 3, 2020
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Sep 3, 2020

@zanderso @blasten

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Sep 3, 2020

Landing on red to fix build

@jonahwilliams jonahwilliams merged commit a864080 into master Sep 3, 2020
@jonahwilliams jonahwilliams deleted the revert-65178-flutter-engine-flutter-autoroll-118f6ddc-301e-4131-ba36-81d029ef03af-1599144125 branch September 3, 2020 17:33
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Revert "Roll Engine from 165abef to e979c29 (42 revisions) (flutter#6…
42e6257 
…5178)" (flutter#65188)

This reverts commit eddf0a8.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @zanderso @googlebot