Add observatory Bonjour service to built iOS Info.plist bundle #65138

jmagman · 2020-09-03T00:14:59Z

Reland #64988, which failed post-submit due to #65124.

Description

Add NSBonjourServices _dartobservatory._tcp and NSLocalNetworkUsageDescription to debug and profile Info.plist in the produced, bundled .app (not the user-facing Info.plist created in the template and included in Xcode).

This prompts the "Your app would like to find and connect to devices on your local network" permission popup, which is required to unblock the observatory publisher on iOS 14.

NSLocalNetworkUsageDescription is underneath:

Note: this does not add the keys for add-to-app host apps, so they still have the issue of blocking the observatory publisher.

Related Issues

Fixes #60634
Fixes #35707.
Related to conversation at #63893, but that is for add-to-app.

Tests

Updated ios_content_validation_test to validate Release does not have the keys, but Debug does.
Move xcode_backend_tests to the command shard, add new behavior tests.

Kudos

Thanks to @gaaclarke for suggesting to just add the keys in the generated bundle Info.plist, and not the one that's created in the template. That avoided a huge migration headache.

Checklist

I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
I read the [Tree Hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.

…er#64988)

jmagman · 2020-09-03T00:17:21Z

packages/flutter_tools/bin/xcode_backend.sh

+  if [[ ! -f "${built_products_plist}" ]]; then
+    EchoError "error: ${INFOPLIST_PATH} does not exist. The Flutter \"Thin Binary\" build phase must run after \"Copy Bundle Resources\"."
+    exit -1
+  fi


This check is new and was not in #64988. If the user rearranged their build scripts manually, error and tell them how to fix it.

Well I get this error but the build script "Thin Binary" is after "Copy Bundle Resources"

@bennibau can you file a new issue and @ mention me? I want to see what's going on in your case.

Please include the output of flutter doctor -v and the full exported Xcode run report.
View > Navigator > Reports > Export...

Also, a screenshot with those build phases expanded.

I'm also hitting this error with this build script:

flutter doctor -v:

[✓] Flutter (Channel master, 1.23.0-8.0.pre.131, on Mac OS X 10.15.6 19G2021 x86_64, locale en-US)
• Flutter version 1.23.0-8.0.pre.131 at /Users/samparks/dev/sdks/flutter
• Framework revision 8485580 (3 hours ago), 2020-10-04 14:47:02 -0400
• Engine revision a8d7d97
• Dart version 2.11.0 (build 2.11.0-185.0.dev)

[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.2)
• Android SDK at /Users/samparks/Library/Android/sdk
• Platform android-30, build-tools 30.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.

[✓] Xcode - develop for iOS and macOS (Xcode 12.0.1)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 12.0.1, Build version 12A7300
• CocoaPods version 1.9.3

[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome

[✓] Android Studio (version 4.0)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 48.1.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)

[✓] VS Code (version 1.49.3)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.15.0

[✓] Connected device (3 available)
• iPhone (mobile) • 00008030-000608880E9B802E • ios • iOS 13.7
• Web Server (web) • web-server • web-javascript • Flutter Tools
• Chrome (web) • chrome • web-javascript • Google Chrome 85.0.4183.121

• No issues found!

jmagman · 2020-09-03T00:17:37Z

packages/flutter_tools/test/integration.shard/xcode_backend_test.dart

+      infoPlist = buildDirectory.childFile('Info.plist');
+    });
+
+    test('fails when the Info.plist is missing', () async {


This test is new.

jmagman · 2020-09-03T00:18:05Z

packages/flutter_tools/test/integration.shard/xcode_backend_test.dart

+    expect(result.exitCode, isNot(0));
+  }
+
+  test('Xcode backend fails with no arguments', () async {


This is new and tests #65124

gaaclarke

LGTM

#65138)" This reverts commit 5e0aa8b.

#65138)" (#65141) This reverts commit 5e0aa8b.

…st bundle (#65138)" (#65141)" This reverts commit 259deec.

…er#65138)

flutter#65138)" (flutter#65141) This reverts commit 5e0aa8b.

…er#65138)

jmagman added 2 commits September 2, 2020 16:35

Add observatory Bonjour service to built iOS Info.plist bundle (flutt…

f8aedfb

…er#64988)

Add xcode_backend test for no args, error on missing Info.plist

a4d6ecc

jmagman added platform-ios iOS applications specifically t: xcode "xcodebuild" on iOS and general Xcode project management labels Sep 3, 2020

jmagman requested review from dnfield and xster September 3, 2020 00:14

jmagman self-assigned this Sep 3, 2020

flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 3, 2020

googlebot added the cla: yes label Sep 3, 2020

jmagman commented Sep 3, 2020

View reviewed changes

gaaclarke approved these changes Sep 3, 2020

View reviewed changes

jmagman merged commit 5e0aa8b into flutter:master Sep 3, 2020

jmagman deleted the bonjour-service branch September 3, 2020 00:57

jmagman added a commit that referenced this pull request Sep 3, 2020

Revert "Add observatory Bonjour service to built iOS Info.plist bundle (

61f2e71

#65138)" This reverts commit 5e0aa8b.

jmagman mentioned this pull request Sep 3, 2020

Revert "Add observatory Bonjour service to built iOS Info.plist bundle" #65141

Merged

jmagman added a commit that referenced this pull request Sep 3, 2020

Revert "Add observatory Bonjour service to built iOS Info.plist bundle (

259deec

#65138)" (#65141) This reverts commit 5e0aa8b.

jmagman added a commit that referenced this pull request Sep 3, 2020

Revert "Revert "Add observatory Bonjour service to built iOS Info.pli…

8030cf6

…st bundle (#65138)" (#65141)" This reverts commit 259deec.

jmagman mentioned this pull request Sep 3, 2020

Add observatory Bonjour service to built iOS Info.plist bundle #65142

Merged

jmagman added a commit that referenced this pull request Sep 3, 2020

Add observatory Bonjour service to built iOS Info.plist bundle (#65138)

ace5442

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Add observatory Bonjour service to built iOS Info.plist bundle (flutt…

55049ea

…er#65138)

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Revert "Add observatory Bonjour service to built iOS Info.plist bundle (

aef74cf

flutter#65138)" (flutter#65141) This reverts commit 5e0aa8b.

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Add observatory Bonjour service to built iOS Info.plist bundle (flutt…

3fdccb3

…er#65138)

jmagman mentioned this pull request Sep 15, 2020

☂️ Support iOS 14 #61047

Closed

30 tasks

jmagman mentioned this pull request Mar 9, 2021

Use app deltas for faster and smaller incremental iOS app installs #67580

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add observatory Bonjour service to built iOS Info.plist bundle #65138

Add observatory Bonjour service to built iOS Info.plist bundle #65138

Uh oh!

jmagman commented Sep 3, 2020 •

edited

Loading

Uh oh!

jmagman Sep 3, 2020

Uh oh!

bennibau Sep 9, 2020

Uh oh!

jmagman Sep 10, 2020

Uh oh!

sam-parks Oct 4, 2020

Uh oh!

jmagman Sep 3, 2020

Uh oh!

jmagman Sep 3, 2020 •

edited

Loading

Uh oh!

gaaclarke left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Add observatory Bonjour service to built iOS Info.plist bundle #65138

Add observatory Bonjour service to built iOS Info.plist bundle #65138

Uh oh!

Conversation

jmagman commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Kudos

Checklist

Breaking Change

Uh oh!

jmagman Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

bennibau Sep 9, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 10, 2020

Choose a reason for hiding this comment

Uh oh!

sam-parks Oct 4, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 3, 2020

Choose a reason for hiding this comment

Uh oh!

jmagman Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gaaclarke left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jmagman commented Sep 3, 2020 •

edited

Loading

jmagman Sep 3, 2020 •

edited

Loading