Skip to content

Revert "Add observatory Bonjour service to built iOS Info.plist bundle" #65109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Sep 2, 2020
Merged

Revert "Add observatory Bonjour service to built iOS Info.plist bundle" #65109

jmagman merged 1 commit into from
Sep 2, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Sep 2, 2020

Reverts #64988

devicelab errors:

2020-09-02T11:44:03.947711: stdout:             ♦ codesign --force --verbose --sign A5CFF7959BD4B17F97127C518E8504F2D9562490 -- /Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Frameworks/Flutter.framework/Flutter
stdout:             /Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Frameworks/Flutter.framework/Flutter: signed bundle with Mach-O universal (armv7 x86_64 arm64) [io.flutter.flutter]
stdout:             /Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Info.plist: file does not exist or is not readable or is not a regular file (Error Domain=NSCocoaErrorDomain Code=260 "The file “Info.plist” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Info.plist, NSUnderlyingError=0x7fe71440c460 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}})
stdout:             ♦ plutil -insert NSBonjourServices -json ["_dartobservatory._tcp"] /Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Info.plist
stdout:             /Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Info.plist: file does not exist or is not readable or is not a regular file (Error Domain=NSCocoaErrorDomain Code=260 "The file “Info.plist” couldn’t be opened because there is no such file." UserInfo={NSFilePath=/Users/flutter/.cocoon/flutter/dev/benchmarks/complex_layout/build/ios/Profile-iphoneos/Runner.app/Info.plist, NSUnderlyingError=0x7fc1a7c0ce70 {Error Domain=NSPOSIXErrorDomain Code=2 "No such file or directory"}})
stdout:             Command PhaseScriptExecution failed with a nonzero exit code

@flutter-dashboard flutter-dashboard bot added c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Sep 2, 2020
@jmagman
Copy link
Member Author

jmagman commented Sep 2, 2020

Merging on red.

@jmagman jmagman merged commit cb81950 into master Sep 2, 2020
@jmagman jmagman deleted the revert-64988-bonjour-service branch September 2, 2020 19:31
jmagman added a commit that referenced this pull request Sep 2, 2020
@jmagman
Revert "Revert "Add observatory Bonjour service to built iOS Info.pli…
2a9c373 
…st bundle (#64988)" (#65109)"

This reverts commit cb81950.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Revert "Add observatory Bonjour service to built iOS Info.plist bundle (
5d96101 
flutter#64988)" (flutter#65109)

This reverts commit 4fde217.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmagman @googlebot