Flutter stable framework 1.20.3 cherrypicks #64984
Conversation
flutter-dashboard
bot
added
a: internationalization
christopherfujino
changed the base branch from
master
to
flutter-1.20-candidate.7
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
flutter-dashboard
bot
changed the base branch from
flutter-1.20-candidate.7
to
master
christopherfujino
changed the base branch from
master
to
flutter-1.20-candidate.7
…). (flutter#64519) Added instructions on how to regenerate certificate too.
Fixes flutter#45075 Fixes flutter#57210 If an asset was included directly from the project root directory, then the same asset when copied to various output or ephemeral directories would also be picked up as an asset variant. This could cause assets to be recursively copied into asset/build/ephemeral directories, as each time it would run it would pick up all of the previous "variants". The solution is to include project ephemeral directories, in addition to the build directory.
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
christopherfujino
requested review from
HansMuller,
a14n,
goderbauer,
jonahwilliams,
pcsosinski and
rami-a
pcsosinski
left a comment
pcsosinski
left a comment
There was a problem hiding this comment.
approved for branch. don't forget to sign the engine :)
Thanks for checking, I did already. |
|
@a14n please look for review, and also CLABot needs consent again :P |
|
@googlebot I consent |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
LGTM |
rami-a
left a comment
rami-a
left a comment
There was a problem hiding this comment.
LGTM for time picker change
|
Re-running Update: passed on re-run, everything is green except for expected failures, which I've tracked in the description. |
|
Sorry, thought @jonahwilliams's was enough. |
Yeah, sorry, I should have been more clear. For extra safety I'm trying out getting multiple reviewers per cherry pick, starting this week. Speaking of which, @goderbauer could you verify the change to |
|
@christopherfujino - Michael is out this week; is there someone else who could LGTM the change to |
Ahh, thanks. In that case, I can LGTM it :) |
|
Merging with the failures all known and issues filed, see PR description for details. |
* Update engine hash to 1.20.3 * Re-enable image_list test with updated certificate(good for 3650 days). (flutter#64519) * [Material] Relanding fix to ensure time picker input mode lays out correctly in RTL (flutter#64097) * allow null in compute for weak mode (flutter#63515) * [flutter_tools] fix recursive asset variant issue (flutter#61129) * [flutter_tool] Handle Windows line endings in packages_test.dart (flutter#63806) * [flutter_tool] Fix some create_test.dart tests on Windows (flutter#63796) Co-authored-by: Alexander Aprelev <[email protected]> Co-authored-by: Rami <[email protected]> Co-authored-by: Alexandre Ardhuin <[email protected]> Co-authored-by: Jonah Williams <[email protected]> Co-authored-by: Zachary Anderson <[email protected]>
10 participants
Scheduled Cherrypicks
d1bc06f032f9d6c148ea6b96b48261d6f545004f021cf56fc97f96e0571bbb13d2c7a6d66de3beffafc9509996b334b71f51f625125c232dce649606741608a261e3b6ac3c36c7ad6cdf798f86733d07Test/Infra-Only Cherrypicks
ed65f5e96cb2437e0315b65df0aba248e3896b45packages_test.dart1884920e30b8d82f2e6408aae1c2b780349d8d00create_test.dartf360d8b8e8a7909c65db0d82b5cb07ab4e7cc0ffPresubmit Known Failures
Linux customer_testingandWindows customer_testingbecause of Pin all repos we clone from HEAD for CI #57062. In the cirrus config, this test was pinned and is green.Linux fuchsia-precachebecause LUCI try-jobs still running latest recipes LUCI try jobs for release branches should use correct builder/recipes #53371.Postsubmit Known Failures
Windows Stable hostonly_devicelab_testsknown failure, these are still red on master but ignored by the build dashboard hostonly_devicelab_tests failing consistently on luci #64466.flutter/galleryin tests #62983 this was pinned upstream in Pin gallery version #62986.customer_testingLinux/Windows known failure, will be fixed by pinning repo checkout on LUCI Pin all repos we clone from HEAD for CI #57062fuchsia_precacheknown failure, will be fixed by being able to skip tasks post-submit [infra] No way to skip builders per-branch on post-submit #64975