Prefer moreOrLessEquals over closeTo #64914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moreOrLessEquals is the preferred mechanism for checking that a value is within some error bound epsilon, with default value for epsilon of precisionErrorTolerance. This patch replaces instances of closeTo using precisionErrorTolerance.
flutter-dashboard
bot
added
the
framework
Member
Author
|
Looks like there's probably a ton more opportunity for cleanup, but this just covers the low-hanging fruit. Update: followup patch in #64915, which covers the non-default cases. That PR is more of a "what do you think?" |
cbracken
changed the title
Hixie
approved these changes
Aug 31, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
moreOrLessEquals is the preferred mechanism for checking that a value is within some error bound epsilon, with default value for epsilon of precisionErrorTolerance. This patch replaces instances of closeTo using precisionErrorTolerance.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
moreOrLessEqualsis the preferred mechanism for checking that a value is within some error bound epsilon, with default value for epsilon of precisionErrorTolerance.This patch replaces instances of
closeTousingprecisionErrorTolerance.