Nnbd widgets #64672
Nnbd widgets #64672
Conversation
flutter-dashboard
bot
added
a: accessibility
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
| /// * [FutureBuilder], which delegates to an [AsyncWidgetBuilder] to build | ||
| /// itself based on a snapshot from interacting with a [Future]. | ||
| typedef AsyncWidgetBuilder<T> = Widget Function(BuildContext context, AsyncSnapshot<T> snapshot); | ||
| typedef AsyncWidgetBuilder<T extends Object> = Widget Function(BuildContext context, AsyncSnapshot<T> snapshot); |
There was a problem hiding this comment.
This extends Object change is failing many google3 tests where generic types are omitted. Example code: https://gist.github.com/goderbauer/244c5f19f69bb36d4a136d176ad189c4
| double get pixels; | ||
|
|
||
| /// Whether the [pixels] property is available. | ||
| bool get hasPixels; |
There was a problem hiding this comment.
This is causing failures in google3 where people extend ViewportOffset.
This reverts commit e682ec7.
This reverts commit 127e679.
This reverts commit 127e679.
8 participants
Description
NNBD migration for widget
Related Issues
Tests
I added the following tests:
None
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.