Fix tests that use bogus objects, update TestImageInfo interface#64599
Merged
Conversation
flutter-dashboard
Bot
added
f: cupertino
dnfield
changed the title
jonahwilliams
approved these changes
Aug 26, 2020
jonahwilliams
left a comment
jonahwilliams
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Thanks for fixing this!
Contributor
Author
|
Found more instances in some other cupertino tests - added them to this. |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
ImageInfoclass says that theimagefield is non-nullable. In trying to update the test interface to match for #64582, I found the tester segfaulted because the cupertino tests I'm fixing here now pass in a bogus dart:ui Image implementation, which results in #64598