Skip to content

Change iOS plugin simulator archs from allow list to deny list #64504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 1 commit into from
Aug 25, 2020
Merged

Change iOS plugin simulator archs from allow list to deny list #64504

jmagman merged 1 commit into from
Aug 25, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 24, 2020 •
edited
Loading

Description

The intention of adding VALID_ARCHS allow list was to exclude i386 simulators. However, at some point Flutter will need to run on the new ARM simulators. Change the allow list to a deny list and just exclude i386.

Related Issues

VALID_ARCHS added in #41828
Discovered with #63252.

Tests

This is already tested in plugin_lint_mac.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@jmagman jmagman self-assigned this Aug 24, 2020
@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 24, 2020
@jmagman jmagman requested a review from xster August 24, 2020 21:15
@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2020

Actually it might be better to declare this in the Flutter.podspec instead of the plugins. Let me try that...

@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2020

Actually it might be better to declare this in the Flutter.podspec instead of the plugins. Let me try that...

Nope it's needed on the plugin, too.

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 24, 2020

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@flutter-dashboard flutter-dashboard bot added the c: contributor-productivity Team-specific productivity, code health, technical debt. label Aug 24, 2020
@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2020

#41828 didn't migrate existing plugins, this one doesn't either. I don't think we have any tooling for migrating this file for existing plugins...

@xster
Copy link
Member

xster commented Aug 25, 2020 •
edited
Loading

LGTM. Good find

@jmagman jmagman merged commit e960d77 into flutter:master Aug 25, 2020
@jmagman jmagman deleted the excluded-archs branch August 25, 2020 00:48
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@jmagman @smadey
Change iOS plugin simulator archs from allow list to deny list (flutt…
abfc2e6 
…er#64504)
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Change iOS plugin simulator archs from allow list to deny list (flutt…
bbef683 
…er#64504)
@jmagman jmagman mentioned this pull request Dec 8, 2020
Merged
This was referenced Mar 2, 2021
Merged
Merged
Merged
@jmagman jmagman mentioned this pull request Jun 23, 2021
Merged
@jmagman jmagman mentioned this pull request Jun 30, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

@christopherfujino christopherfujino Awaiting requested review from christopherfujino

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jmagman @xster @googlebot