Repository navigation
Remove default horizontal padding for Input. - #6437
Merged
Merged
Conversation
This partially reverts #626 , but horizontal padding is not in the spec, so we still match the spec.
Contributor
|
LGTM. Note that a side-effect here will be that tapping the edge of an input that has padding won't work any more, since the gesture detector is moving from outside the padding to inside the padding. An alternative solution would be to just make the padding on the input configurable. |
Contributor
Author
|
Yeah, I considered adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially reverts #626 ,
but horizontal padding is not in the spec, so we still match the spec.