Skip to content

Remove default horizontal padding for Input. - #6437

Merged
mpcomplete merged 1 commit into
flutter:masterfrom
mpcomplete:input.padding
Oct 20, 2016
Merged

mpcomplete merged 1 commit into
flutter:masterfrom
mpcomplete:input.padding

Conversation

@mpcomplete

Copy link
Copy Markdown
Contributor

This partially reverts #626 ,
but horizontal padding is not in the spec, so we still match the spec.

This partially reverts #626 ,
but horizontal padding is not in the spec, so we still match the spec.
@Hixie

Hixie commented Oct 20, 2016

Copy link
Copy Markdown
Contributor

LGTM.

Note that a side-effect here will be that tapping the edge of an input that has padding won't work any more, since the gesture detector is moving from outside the padding to inside the padding.

An alternative solution would be to just make the padding on the input configurable.

@mpcomplete

Copy link
Copy Markdown
Contributor Author

Yeah, I considered adding a padding argument to Input, but it seemed unnecessary and inconsistent (would all material controls have controllable padding?). Also, seeing it in practice, I don't expect a tap on the empty padding space to focus the Input control, so that doesn't seem like an issue to me.

@mpcomplete
mpcomplete merged commit fdb76da into flutter:master Oct 20, 2016
@mpcomplete
mpcomplete deleted the input.padding branch October 20, 2016 20:38
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants