Revert "Ensure time picker input mode lays out correctly in RTL" #64094
+49
−188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)" This reverts commit 1de673b.
flutter-dashboard
bot
added
a: internationalization
Member
|
Can you please include some information regarding why a PR was reverted in a revert? |
13 tasks
Contributor
|
Added a comment about why it was reverted in the description |
Member
|
Thanks! |
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
…ter#63599)" (flutter#64094) This reverts commit 1de673b.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…ter#63599)" (flutter#64094) This reverts commit 1de673b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #63599
This was reverted because #63599, the ":" separator became vertically offset from the hours and minutes because of the addition of a nested Row widget that didn't specify the crossAxisAlignment appropriately. This ended up being caught by internal screenshot tests and so was reverted.