Skip to content

Revert "Roll Engine from 7571e7c380fd to b300be3df32b (60 revisions)" #63969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonahwilliams merged 1 commit into from
Aug 17, 2020
Merged

Revert "Roll Engine from 7571e7c380fd to b300be3df32b (60 revisions)" #63969

jonahwilliams merged 1 commit into from
Aug 17, 2020

Conversation

@jonahwilliams
Copy link
Contributor

@jonahwilliams jonahwilliams commented Aug 17, 2020

Reverts #63892

android_view_scroll_perf_timeline_summary is failing:

2020-08-16T03:19:12.369706: stdout: [ +184 ms] E/flutter (32299): [ERROR:flutter/shell/platform/android/platform_view_android_jni_impl.cc(43)] java.lang.NullPointerException: Attempt to invoke virtual method 'void android.view.View.setVisibility(int)' on a null object reference
2020-08-16T03:19:12.370092: stdout: [        ] E/flutter (32299): 	at io.flutter.plugin.platform.PlatformViewsController.finishFrame(PlatformViewsController.java:810)
2020-08-16T03:19:12.371146: stdout: [        ] E/flutter (32299): 	at io.flutter.plugin.platform.PlatformViewsController.onEndFrame(PlatformViewsController.java:771)
stdout: [        ] E/flutter (32299): 	at io.flutter.embedding.engine.FlutterJNI.onEndFrame(FlutterJNI.java:856)
2020-08-16T03:19:12.371823: stdout: [        ] E/flutter (32299): 	at android.os.MessageQueue.nativePollOnce(Native Method)
2020-08-16T03:19:12.372393: stdout: [        ] E/flutter (32299): 	at android.os.MessageQueue.next(MessageQueue.java:323)
2020-08-16T03:19:12.372773: stdout: [        ] E/flutter (32299): 	at android.os.Looper.loop(Looper.java:136)
2020-08-16T03:19:12.373525: stdout: [        ] E/flutter (32299): 	at android.app.ActivityThread.main(ActivityThread.java:6123)
2020-08-16T03:19:12.374160: stdout: [        ] E/flutter (32299): 	at java.lang.reflect.Method.invoke(Native Method)
2020-08-16T03:19:12.374659: stdout: [        ] E/flutter (32299): 	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:867)
2020-08-16T03:19:12.375206: stdout: [        ] E/flutter (32299): 	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:757)

@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Aug 17, 2020
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Aug 17, 2020

@gaaclarke

@gaaclarke
Copy link
Member

gaaclarke commented Aug 17, 2020 •
edited
Loading

@jonahwilliams can you link directly to the errors please. I'm poking around in the dashboard and haven't seen this failure yet.

edit: Ok, i think I see the value missing at least.

@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Aug 17, 2020

I can't, its just a log download link - I include the relevant part of the error and the failing test name

@jonahwilliams jonahwilliams mentioned this pull request Aug 17, 2020
Merged
@jonahwilliams
Copy link
Contributor Author

jonahwilliams commented Aug 17, 2020

Revert analysis errors on ToT: #63972

Should be safe to land now

@jonahwilliams jonahwilliams merged commit c89402c into master Aug 17, 2020
@jonahwilliams jonahwilliams deleted the revert-63892-flutter-engine-flutter-autoroll-76175487-8c07-42ba-bd0c-99755c248c1a-1597568891 branch August 17, 2020 17:25
@gaaclarke gaaclarke mentioned this pull request Aug 17, 2020
Merged
12 tasks
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@smadey
Revert "Roll Engine from 7571e7c to b300be3 (60 revisions) (flutter#6…
20daf22 
…3892)" (flutter#63969)

This reverts commit b2c0970.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Revert "Roll Engine from 7571e7c to b300be3 (60 revisions) (flutter#6…
5314066 
…3892)" (flutter#63969)

This reverts commit b2c0970.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

engine flutter/engine related. See also e: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonahwilliams @gaaclarke @googlebot