Do not reassemble the application after a hot reload if the isolate is paused #6370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
devoncarew
reviewed
Oct 20, 2016
Contributor
There was a problem hiding this comment.
This should probably be a printTrace to match the Reassembling application message below. If this should be user-facing, we may want to update the message to make it clearer to the user what's happening.
Contributor
|
lgtm |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pauseEventtoIsolate.PausePostRequestpause kind.Now when the isolate is paused after a hot reload, we do not invoke any Dart code in the isolate and leave control in the debug clients. This allows for debug clients to set breakpoints, etc after a reload.