Skip to content

Conversation

@rami-a
Copy link
Contributor

@rami-a rami-a commented Aug 12, 2020

Description

This is a follow-up to #62803 and ensures that the hours and minutes are laid out correctly for RTL for the time picker input mode (the previous PR only fixed the clock dial mode).

Related Issues

Fixes #63427

Tests

I added the following tests:

  • a test to check the position of elements in various locales including an RTL one

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 12, 2020
@rami-a rami-a requested a review from HansMuller August 12, 2020 18:57
Copy link
Contributor

@HansMuller HansMuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rami-a rami-a merged commit 1de673b into flutter:master Aug 13, 2020
@rami-a rami-a deleted the time-picker-input-rtl branch August 13, 2020 18:16
mehmetf added a commit that referenced this pull request Aug 18, 2020
mehmetf added a commit that referenced this pull request Aug 18, 2020
rami-a added a commit to rami-a/flutter that referenced this pull request Aug 18, 2020
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Wrong hour/minute order in timePicker in RTL mode

5 participants