-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Ensure time picker input mode lays out correctly in RTL #63599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HansMuller
approved these changes
Aug 12, 2020
Contributor
HansMuller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
johnsonmh
approved these changes
Aug 12, 2020
mehmetf
added a commit
that referenced
this pull request
Aug 18, 2020
…)" This reverts commit 1de673b.
mehmetf
added a commit
that referenced
this pull request
Aug 18, 2020
rami-a
added a commit
to rami-a/flutter
that referenced
this pull request
Aug 18, 2020
13 tasks
smadey
pushed a commit
to smadey/flutter
that referenced
this pull request
Aug 27, 2020
…ter#63599)" (flutter#64094) This reverts commit 1de673b.
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
…ter#63599)" (flutter#64094) This reverts commit 1de673b.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
a: internationalization
Supporting other languages or locales. (aka i18n)
f: material design
flutter/packages/flutter/material repository.
framework
flutter/packages/flutter repository. See also f: labels.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow-up to #62803 and ensures that the hours and minutes are laid out correctly for RTL for the time picker input mode (the previous PR only fixed the clock dial mode).
Related Issues
Fixes #63427
Tests
I added the following tests:
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.