Skip to content

1.20.2 Cherrypicks #63591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pcsosinski merged 7 commits into from
Aug 13, 2020
Merged

1.20.2 Cherrypicks #63591

pcsosinski merged 7 commits into from
Aug 13, 2020

Conversation

@pcsosinski
Copy link

@pcsosinski pcsosinski commented Aug 12, 2020 •
edited
Loading

@flutter-dashboard
Copy link

flutter-dashboard bot commented Aug 12, 2020

This pull request was opened from and to a release candidate branch. This should only be done as part of the official Flutter release process. If you are attempting to make a regular contribution to the Flutter project, please close this PR and follow the instructions at Tree Hygiene for detailed instructions on contributing to Flutter.

Reviewers: Use caution before merging pull requests to release branches. Ensure the proper procedure has been followed.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. work in progress; do not review labels Aug 12, 2020
@pcsosinski pcsosinski marked this pull request as ready for review August 13, 2020 03:17
@pcsosinski pcsosinski requested a review from jmagman as a code owner August 13, 2020 03:17
@flutter-dashboard flutter-dashboard bot added the engine flutter/engine related. See also e: labels. label Aug 13, 2020
shihaohong
shihaohong approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The DatePicker localizations files LGTM.

rami-a
rami-a approved these changes Aug 13, 2020
View reviewed changes
Copy link
Contributor

@rami-a rami-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Time Picker changes and l10n look good to me

@pcsosinski pcsosinski merged commit bbfbf17 into flutter:flutter-1.20-candidate.7 Aug 13, 2020
@pcsosinski pcsosinski deleted the flutter-1.20-candidate.7 branch August 13, 2020 15:33
@kndl22 kndl22 mentioned this pull request Sep 6, 2020
Closed
maged200 added a commit to maged200/flutter that referenced this pull request Nov 9, 2020
@maged200
Revert "1.20.2 Cherrypicks (flutter#63591)"
ecee56f 
This reverts commit bbfbf17.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman Awaiting requested review from jmagman jmagman is a code owner

@darrenaustin darrenaustin Awaiting requested review from darrenaustin

@Piinks Piinks Awaiting requested review from Piinks

2 more reviewers

@rami-a rami-a rami-a approved these changes

@shihaohong shihaohong shihaohong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

a: internationalization Supporting other languages or locales. (aka i18n) c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pcsosinski @rami-a @shihaohong @googlebot @Piinks @jmagman @darrenaustin