Add support for persistent footer buttons #6345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Member
|
LGTM |
HansMuller
reviewed
Oct 17, 2016
Contributor
There was a problem hiding this comment.
I suppose you could also check for config.persistentFooterButtons.length > 0. On the other hand, maybe it's better to have the substructure in place for the inevitable rebuild with a non-empty buttons list.
Contributor
Author
There was a problem hiding this comment.
Yeah, I figured it would be better to treat an empty list by drawing the bar and leaving a null list as the way to get rid of the bar.
Contributor
|
LGTM too. |
abarth
force-pushed
the
persistent_bottom_buttons
branch
from
f3d69ab to
2262b88
Compare
Contributor
|
We'll eventually have to add a way for these buttons to slide away when the body is scrolled up and slide back when the body is scrolled down. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #616