Tweaked scroll simulation for iOS platform #6334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarth
reviewed
Oct 14, 2016
| scrollDrag, position, velocity, double.NEGATIVE_INFINITY, double.INFINITY | ||
| return new ScrollSimulation( | ||
| position: position, | ||
| velocity: velocity, |
Contributor
Author
There was a problem hiding this comment.
Oops. I will fix that.
Contributor
|
LGTM We should probably move ScrollSimulation out of the physics library. It's not really an immutable law of physics how things scroll. :) |
Contributor
Author
|
That's a good point about ScrollSimulation, I wasn't happy putting the platform-specific stuff in there. I've moved it. |
Contributor
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the new Android scroll simulation for the moment.
The platform-specific stuff has moved from the ScrollBehavior classes to the ScrollSimulation class which now uses keyword parameters.