Repository navigation
Navigator.push and Navigator.pushNamed should return Futures - #6333
Merged
Merged
Conversation
Contributor
Author
Hixie
reviewed
Oct 14, 2016
Contributor
There was a problem hiding this comment.
maybe this function should take an optional named argument to pass to pop
Hixie
reviewed
Oct 14, 2016
Contributor
There was a problem hiding this comment.
we should mention these details (from the removed comment) maybe in the completed docs or something
Contributor
Author
There was a problem hiding this comment.
Good idea. (I think these docs were actually backwards, fwiw)
Contributor
There was a problem hiding this comment.
specifically the relative timings of these futures resolving
Contributor
|
Thanks for doing this. |
Contributor
Author
|
Had to tweak how overlay route works. See |
Hixie
reviewed
Oct 14, 2016
Contributor
|
that change makes sense. LGTM. |
These futures complete when the route is popped off the navigator. This generalizes and simplifies a mechanism already in place for dialogs and menus. Fixes flutter#5283
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These futures complete when the route is popped off the navigator. This
generalizes and simplifies a mechanism already in place for dialogs and
menus.
Fixes #5283