Skip to content

Conversation

@clarkezone
Copy link

Description

Fixes #63299 by passing the correct window size to the constructor of FlutterViewController rather than a temporary value.

This change is dependent on flutter/engine#20357 landing first.

Related Issues

#40068

Tests

No change in behavior introduced.

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [] I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added the tool Affects the "flutter" command-line tool. See also t: labels. label Aug 8, 2020
@clarkezone
Copy link
Author

CR feedback addres, I’m going to do one final check to confirm that we are indeed only creating a single surface on startup, now that the dependent change is in, then I think we’re good here once the tree goes green

@clarkezone
Copy link
Author

OK, verified that there is only one surface creation now

Copy link
Contributor

@stuartmorgan-g stuartmorgan-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a whitespace fix; LGTM with that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Windows] Multiple surfaces create / destroy during startup

4 participants