Skip to content

Bump Cirrus image Xcode version #63252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jmagman merged 2 commits into from
Aug 25, 2020
Merged

Bump Cirrus image Xcode version #63252

jmagman merged 2 commits into from
Aug 25, 2020

Conversation

@jmagman
Copy link
Member

@jmagman jmagman commented Aug 8, 2020

Description

Update Cirrus macOS image to catalina-xcode-12.0-flutter.

Related Issues

#60133

@jmagman jmagman added c: contributor-productivity Team-specific productivity, code health, technical debt. team-infra Owned by Infrastructure team platform-ios iOS applications specifically labels Aug 8, 2020
@jmagman jmagman self-assigned this Aug 8, 2020
@jmagman jmagman mentioned this pull request Aug 8, 2020
Closed
8 tasks
@fkorotkov
Copy link
Contributor

fkorotkov commented Aug 11, 2020

@jmagman you can re-run the macOS tasks. catalina-xcode-12.0-flutter image is available now.

@jmagman
Copy link
Member Author

jmagman commented Aug 11, 2020

@jmagman you can re-run the macOS tasks. catalina-xcode-12.0-flutter image is available now.

Kicked it off, thank you!

@jmagman jmagman marked this pull request as ready for review August 11, 2020 19:53
@fkorotkov fkorotkov mentioned this pull request Aug 12, 2020
Merged
@jmagman
Copy link
Member Author

jmagman commented Aug 12, 2020

Investigating new test failure:

[plugin_lint_mac] [STDOUT] stdout:     ld: building for iOS Simulator, but linking in dylib built for iOS, file '/var/folders/3y/l0z1x3693dl_8n0qybp4dqwh0000gn/T/CocoaPods-Lint-20200812-67637-y2vglb-test_plugin_objc/Pods/Flutter/Flutter.framework/Flutter' for architecture arm64
[plugin_lint_mac] [STDOUT] stdout:     clang: error: linker command failed with exit code 1 (use -v to see invocation)

@xster
Copy link
Member

xster commented Aug 12, 2020

LGTM

@fkorotkov
Copy link
Contributor

fkorotkov commented Aug 14, 2020

@jmagman since this PR is not yet merged, will it be OK if I'll update he 12.0 image to have Android SDK 30? Seem #63517 will be merged first?

@jmagman
Copy link
Member Author

jmagman commented Aug 14, 2020

@jmagman since this PR is not yet merged, will it be OK if I'll update he 12.0 image to have Android SDK 30? Seem #63517 will be merged first?

@fkorotkov Sure, I haven't had time to investigate the new test failure.

@xster
Copy link
Member

xster commented Aug 21, 2020

Seems like the remaining issue is

ld: warning: ignoring file /Users/anka/Library/Developer/Xcode/DerivedData/App-avzfybhzqsdeagahoaqdlscqhsot/Build/Products/Release-iphonesimulator/test_plugin_objc/test_plugin_objc.framework/test_plugin_objc, building for iOS Simulator-i386 but attempting to link with file built for iOS Simulator-x86_64

@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2020 •
edited
Loading

@xster That's a known warning, the error is ld: building for iOS Simulator, but linking in dylib built for iOS

@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2020 •
edited
Loading

Flutter only has a x86_64 simulator slice (the arm slice is iphoneos not iphonesimulator).
ARM macOS developers will see the same error when they try to run Flutter on simulators...
Edit: Also on non-ARM macOS when ONLY_ACTIVE_ARCH=NO, which is only off by default in Release configuration.

@jmagman jmagman mentioned this pull request Aug 24, 2020
Merged
10 tasks
@jmagman
Copy link
Member Author

jmagman commented Aug 24, 2020

Filed #64502.

jmagman
jmagman commented Aug 25, 2020
View reviewed changes
dev/devicelab/bin/tasks/plugin_lint_mac.dart
'LANG': 'en_US.UTF-8',
},
// TODO(jmagman): Flutter cannot build against ARM simulators https://github.com/flutter/flutter/issues/64502
canFail: true,
Copy link
Member Author

@jmagman jmagman Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sucks.
The plugin linter tests are going to hit this problem with Xcode 12, too.
\cc @cyanglaz

Copy link
Contributor

@cyanglaz cyanglaz Aug 25, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the syntax. Does "canFail" make the analyzer pass even hitting this problem?

Copy link
Member Author

@jmagman jmagman Aug 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's running this check but not failing the test if the linter fails. Flutter is missing an ARM simulator slice, so will fail on Xcode 12.

@jmagman jmagman requested a review from xster August 25, 2020 01:07
@jmagman jmagman mentioned this pull request Aug 25, 2020
Closed
@xster
Copy link
Member

xster commented Aug 25, 2020

LGTM

@jmagman jmagman merged commit bd7e2ee into flutter:master Aug 25, 2020
@jmagman jmagman deleted the cirrus-xcode-12 branch August 25, 2020 17:34
smadey pushed a commit to smadey/flutter that referenced this pull request Aug 27, 2020
@jmagman @smadey
Bump Cirrus image Xcode version (flutter#63252)
c6229e3
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@jmagman @mingwandroid
Bump Cirrus image Xcode version (flutter#63252)
91b324a
@jmagman jmagman mentioned this pull request Mar 2, 2021
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@xster xster Awaiting requested review from xster

1 more reviewer

@cyanglaz cyanglaz cyanglaz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jmagman jmagman

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. platform-ios iOS applications specifically team-infra Owned by Infrastructure team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jmagman @fkorotkov @xster @cyanglaz @googlebot