Skip to content

move compile/target sdk versions to 29 (#62799) #63008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 3 commits into from
Aug 11, 2020
Merged

move compile/target sdk versions to 29 (#62799) #63008

fluttergithubbot merged 3 commits into from
Aug 11, 2020

Conversation

@xster
Copy link
Member

@xster xster commented Aug 5, 2020 •
edited
Loading

Unrevert #62884

Fixed revert by fixing permissions on devicelab. Also add checks in doctor validation.
#54382

@xster xster requested a review from jonahwilliams August 5, 2020 19:11
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 5, 2020
@xster xster force-pushed the android-29-template branch from 9739229 to da1048a Compare August 6, 2020 21:02
@xster
Copy link
Member Author

xster commented Aug 7, 2020

@fkorotkov do you know what's up with these tests? Do we need to install Java ourselves on these linux dockers?

@fkorotkov
Copy link
Contributor

fkorotkov commented Aug 7, 2020

I think @jmagman provided some insights on Discord about the issue. Please let me know if I can help you somehow.

@jmagman
Copy link
Member

jmagman commented Aug 7, 2020

I think @jmagman provided some insights on Discord about the issue. Please let me know if I can help you somehow.

The test has Android SDK 28.0.3 installed, you bumped the requirement to 29, but there will be a doctor error until there's some automatic download building the Android app. And the doctor validation fails in setup too.

@jmagman jmagman mentioned this pull request Aug 10, 2020
Closed
@xster xster force-pushed the android-29-template branch from da1048a to a84f3df Compare August 11, 2020 19:21
@xster
Copy link
Member Author

xster commented Aug 11, 2020

🤦🏻‍♂️ yup.

Moving the doctor check to another PR since updating the min required SDK for all projects (and modifying Cirrus's docker file) vs updating the template which self-upgrades are 2 different semantic steps anyway.

@fluttergithubbot fluttergithubbot merged commit df8e537 into flutter:master Aug 11, 2020
@bernaferrari
Copy link
Contributor

bernaferrari commented Aug 12, 2020

Is there a reason you didn't choose API 30 which is the latest?

@jmagman
Copy link
Member

jmagman commented Aug 12, 2020

@bernaferrari see #56597

@Abhishek01039 Abhishek01039 mentioned this pull request Aug 25, 2020
Closed
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@xster @mingwandroid
move compile/target sdk versions to 29 (flutter#62799) (flutter#63008)
d3d09e8
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@zanderso zanderso zanderso approved these changes

@jonahwilliams jonahwilliams Awaiting requested review from jonahwilliams

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@xster @fkorotkov @jmagman @bernaferrari @zanderso @fluttergithubbot