Skip to content

Conversation

@domesticmouse
Copy link
Contributor

Dropped from ~120 errors to 2 when editing the flutter_gallery sample app in Atom.io

@abarth
Copy link
Contributor

abarth commented Oct 13, 2016

You're probably using an old version of the Dart SDK. We recommend configuring Atom to use the version of the Dart SDK in flutter/bin/cache/dart-sdk.

In particular, these trailing commas are now allowed in the Dart language (and they make dartfmt produce prettier code in these cases).

@domesticmouse
Copy link
Contributor Author

The dart version for the flutter/bin/cache/dart-sdk is Dart VM version: 1.20.0-dev.10.2 (Wed Oct 12 10:35:48 2016) on "macos_x64", but my brew installed dart version is Dart VM version: 1.19.1 (Wed Sep 7 08:59:17 2016) on "macos_x64", which is the one I assume Atom is using to run the analysis from?

@abarth
Copy link
Contributor

abarth commented Oct 13, 2016

If you look at the plugin settings for the dartlang plugin in Atom, it will tell you which one it is using.

@domesticmouse
Copy link
Contributor Author

Would you believe Atom was using a 1.17 version of dart? Sorry for the noise!

@abarth
Copy link
Contributor

abarth commented Oct 13, 2016

Ah! Yeah, I thought we had waited until trailing commas were in the stable version of the SDK before using them. Thanks for digging into the issue.

@domesticmouse
Copy link
Contributor Author

I can confirm everything is happy, now that Atom is configured to use the flutter/bin/cache/dart-sdk with a fresh checkout of flutter.

@Hixie
Copy link
Contributor

Hixie commented Oct 13, 2016

Does flutter doctor check whether the IDEs are configured to use the right Dart SDK?

@domesticmouse
Copy link
Contributor Author

@Hixie as yet, no. Want me to raise a FR somewhere?

@Hixie
Copy link
Contributor

Hixie commented Oct 14, 2016

Yes please! That would be a good thing to catch. Thanks!

GaryQian added a commit that referenced this pull request Sep 22, 2018
Unbreak build.

git log a8890fd..cc3009c --no-merges --oneline
cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (#6309)
bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (#6307)
dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (#6308)
d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257)
2a1debf Update deprecated subtags from language subtag registry. (#6280)
540cd96 Add Xib splashscreen support (#6289)
05f21e6 (main) Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279)
ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (#6304)
3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (#6302)
0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (#6301)
cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (#6299)
2ec20aa Remove bottom safe-area padding when keyboard up (#6297)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants