-
Notifications
You must be signed in to change notification settings - Fork 29.7k
Making Atom show a lot less errors #6297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
You're probably using an old version of the Dart SDK. We recommend configuring Atom to use the version of the Dart SDK in In particular, these trailing commas are now allowed in the Dart language (and they make dartfmt produce prettier code in these cases). |
|
The |
|
If you look at the plugin settings for the dartlang plugin in Atom, it will tell you which one it is using. |
|
Would you believe Atom was using a 1.17 version of dart? Sorry for the noise! |
|
Ah! Yeah, I thought we had waited until trailing commas were in the stable version of the SDK before using them. Thanks for digging into the issue. |
|
I can confirm everything is happy, now that Atom is configured to use the |
|
Does |
|
@Hixie as yet, no. Want me to raise a FR somewhere? |
|
Yes please! That would be a good thing to catch. Thanks! |
Unbreak build. git log a8890fd..cc3009c --no-merges --oneline cc3009c Revert 'Dart SDK roll for 2018/09/20' 8471862 (#6309) bbdf7c1 Revert "Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0." (#6307) dea0921 Roll src/third_party/skia c25f440d537e..358558a4cecc (17 commits) (#6308) d29c7db Add logging if FlutterDartProject fails to load the application kernel snapshot (#6257) 2a1debf Update deprecated subtags from language subtag registry. (#6280) 540cd96 Add Xib splashscreen support (#6289) 05f21e6 (main) Fix a compilation problem when using iPhoneOS12.0sdk(Xcode10) && clang version 7.0.0. (#6279) ca6f103 Roll src/third_party/skia d842557c0724..c25f440d537e (10 commits) (#6304) 3b46705 Roll src/third_party/skia 38ca6d509d9f..d842557c0724 (5 commits) (#6302) 0c166fe Roll src/third_party/skia 05cf051f0252..38ca6d509d9f (1 commits) (#6301) cf0fbad Roll src/third_party/skia 44c6167c4125..05cf051f0252 (4 commits) (#6299) 2ec20aa Remove bottom safe-area padding when keyboard up (#6297)
Dropped from ~120 errors to 2 when editing the flutter_gallery sample app in Atom.io