Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 4, 2020

Reverting the "removing no-op" ios folder change.

The change was first landed on master in 004f90f
and cherry-picked within #62372

We plan to re-land this along with #62885 after 1.20 is released.

@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

1 similar comment
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.20-candidate.7 to master August 4, 2020 20:35
@flutter-dashboard flutter-dashboard bot requested a review from jmagman as a code owner August 4, 2020 20:35
@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 4, 2020
@cyanglaz cyanglaz changed the base branch from master to flutter-1.20-candidate.7 August 4, 2020 20:37
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 4, 2020

@csells As discussed offline, can we land the "removing no-op ios folder" change after 1.20 is released?

@cyanglaz cyanglaz requested review from csells and pcsosinski August 4, 2020 20:39
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, up to @pcsosinski

Copy link

@pcsosinski pcsosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

customer_testing failures are expected (fix coming later today to pin to working versions)

@cyanglaz cyanglaz merged commit 7696e55 into flutter:flutter-1.20-candidate.7 Aug 4, 2020
@cyanglaz cyanglaz deleted the revert_ios_folder_removal branch August 4, 2020 23:24
@cyanglaz cyanglaz restored the revert_ios_folder_removal branch August 5, 2020 17:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants