Skip to content

Conversation

@rami-a
Copy link
Contributor

@rami-a rami-a commented Aug 4, 2020

Description

This change just updates localized strings with the latest translations internally.

PRs

Fixes #55535

Tests

I added the following tests:

No need for tests, this is just updating via an internal script

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@flutter-dashboard flutter-dashboard bot added a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository. labels Aug 4, 2020
@rami-a
Copy link
Contributor Author

rami-a commented Aug 4, 2020

@shihaohong @HansMuller a few changes I wasn't sure about.

  • The kn locale changes look off
  • The nb locale are new files, do we want these?

@rami-a rami-a requested review from HansMuller and shihaohong August 4, 2020 19:19
@shihaohong
Copy link
Contributor

shihaohong commented Aug 5, 2020

@rami-a

Regarding the _nb files:

The _nb.arb files are unexpected due to #53880. The tldr; here is that we use _no.arb files to generate localizations for both nb and no locales now to accommodate having no for "Google-canonical" support and nb for platforms like Android that do not recognize no. I'll probably need to look into how the script that pulls down new arb files from Google, it seems like something might've changed in the translation console or there's been a bug in the script.

Edit: For now, could you manually remove the addition of the _nb.arb files before running gen_localizations.dart, and then message me a pointer to how you pulled down the arb files from Google? Thanks!
Edit2: Weird, I just tried to run the script myself and it doesn't seem to generate _nb.arb files at all. I only get modifications to the existing _no.arb files.
Edit3: I tried again the next day and the _nb.arb were generated, although for some reason it only contained more recent messages (note that https://github.com/flutter/flutter/pull/62896/files#diff-8e7e307b338fde96622bfa9a1a5d7261 only contains the latest date picker translations and not the older messages)

Regarding the _kn changes:

The characters should be escaped due to the crash it causes for some emacs users. Once you run https://github.com/flutter/flutter/blob/master/dev/tools/localization/bin/gen_localizations.dart to update the dart translation source code, it should automatically escape the characters for you in both the generated dart translation source code, as well as the arb files.

@shihaohong
Copy link
Contributor

Closing PR since #63026 has already been merged

@shihaohong shihaohong closed this Aug 6, 2020
@rami-a rami-a deleted the translations branch August 6, 2020 16:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

a: internationalization Supporting other languages or locales. (aka i18n) f: cupertino flutter/packages/flutter/cupertino repository f: material design flutter/packages/flutter/material repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New datepicker (channel stable): Language always English + manually entering date doesn't work in other languages/ regions

3 participants