Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Aug 4, 2020

Description

1.20 cherry pick of #62605

Related Issues

#60215

@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.20-candidate.7 to master August 4, 2020 18:26
@flutter-dashboard flutter-dashboard bot changed the base branch from flutter-1.20-candidate.7 to master August 4, 2020 18:26
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

1 similar comment
@flutter-dashboard
Copy link

This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick.

@flutter-dashboard flutter-dashboard bot added engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 4, 2020
@jmagman jmagman changed the base branch from master to flutter-1.20-candidate.7 August 4, 2020 18:27
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmagman jmagman requested a review from pcsosinski August 4, 2020 18:27
@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 4, 2020

@pcsosinski Tests failed due to branch's sdk version less than 1.20.0.

@pcsosinski
Copy link

@christopherfujino to make sure we're doing the right thing here wrt versioning and the tests.

@tvolkert
Copy link
Contributor

tvolkert commented Aug 4, 2020

This will yield version solving issues for users on the beta channel before this release is published as 1.20.0

@pcsosinski
Copy link

so do we need to release 1.20.0 and then a 1.20.1?

@pcsosinski pcsosinski closed this Aug 4, 2020
@pcsosinski pcsosinski reopened this Aug 4, 2020
@pcsosinski
Copy link

what if we just make it > 1.19.1?

@tvolkert
Copy link
Contributor

tvolkert commented Aug 4, 2020

>1.19.0 should work

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 5, 2020

After offline discussion with @pcsosinski and @csells, we will close this PR. And after 1.20.0's release, we will introduce a hotfix with #62939

@pcsosinski
Copy link

stable has versioned to 1.20.0.

@cyanglaz
Copy link
Contributor Author

cyanglaz commented Aug 5, 2020

closing in favor of #62939

@cyanglaz cyanglaz closed this Aug 5, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

c: contributor-productivity Team-specific productivity, code health, technical debt. engine flutter/engine related. See also e: labels. framework flutter/packages/flutter repository. See also f: labels. tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants