-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[CP] Set plugin template min flutter sdk version to 1.20 #62885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CP] Set plugin template min flutter sdk version to 1.20 #62885
Conversation
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
1 similar comment
|
This pull request was opened against a branch other than master. Since Flutter pull requests should not normally be opened against branches other than master, I have changed the base to master. If this was intended, you may modify the base back to flutter-1.20-candidate.7. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than master, unless this is an intentional hotfix/cherrypick. |
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@pcsosinski Tests failed due to branch's sdk version less than 1.20.0. |
|
@christopherfujino to make sure we're doing the right thing here wrt versioning and the tests. |
|
This will yield version solving issues for users on the beta channel before this release is published as |
|
so do we need to release 1.20.0 and then a 1.20.1? |
|
what if we just make it > 1.19.1? |
|
|
|
After offline discussion with @pcsosinski and @csells, we will close this PR. And after 1.20.0's release, we will introduce a hotfix with #62939 |
|
stable has versioned to 1.20.0. |
|
closing in favor of #62939 |
Description
1.20 cherry pick of #62605
Related Issues
#60215