Address misc time picker design issues #62803

rami-a · 2020-08-03T18:44:12Z

Description

This change makes small tweaks to time picker to ensure it matches the design spec (to be published soon!)

Using bodyText1 on the dial numbers instead of subtitle1
Making sure dial numbers use color scheme values
Limit textfield entry to 2 characters
Ensure providing a custom inputDecorationTheme still allows the focused fill color behavior
Ensure that when locale is RTL, the hours/minutes do not get swapped

Related Issues

Fixes #62775

Tests

I added the following tests:

Updated existing tests

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the Contributor Guide and followed the process outlined there for submitting PRs.
I signed the CLA.
I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
I read the Tree Hygiene wiki page, which explains my responsibilities.
I updated/added relevant documentation (doc comments with ///).
All existing and new tests are passing.
The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

willlarche

LGTM

willlarche · 2020-08-03T18:52:02Z

packages/flutter/lib/src/material/time_picker.dart

        child: TextFormField(
          expands: true,
          maxLines: null,
+          inputFormatters: <TextInputFormatter>[


maxLines has to be null for the expands logic to work, so we limit to 2 characters

willlarche · 2020-08-03T18:52:23Z

packages/flutter/lib/src/material/time_picker.dart

          ),
          onPressed: _handleEntryModeToggle,
-          icon: Icon(_entryMode == TimePickerEntryMode.dial ? Icons.keyboard : Icons.access_time),
+          icon: Icon(_entryMode == TimePickerEntryMode.dial ? Icons.keyboard_outlined : Icons.access_time),


Outlined for M2?

yep that is expected

HansMuller

LGTM however these changes are likely to break golden image tests.

rami-a · 2020-08-03T20:19:51Z

I've disabled my internal golden tests while I work through these changes internally and externally. So I think it will be ok to land this

fluttergithubbot · 2020-08-03T21:16:05Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite Linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite Windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite framework_tests-libraries-windows has failed. Please fix the issues identified (or deflake) before re-applying this label.
The status or check suite framework_tests-libraries-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

fluttergithubbot · 2020-08-04T16:36:02Z

This pull request is not suitable for automatic merging in its current state.

The status or check suite web_tests-3-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.

pcsosinski · 2020-08-10T16:08:56Z

removing CP label in favor of #62775

* Fix SliverList scrollOffsetCorrection 0 case (#62615) * Case insensitive check flavor names against Xcode schemes (#61140) * Address misc time picker design issues (#62803) * Update to the latest localizations (#63026) * Removed the inputFormatters from the text input fields used by the Date Pickers (#63461) * Fix App.framework path in Podfile (#63412) * Update engine hash to 1.20.2 Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Rami <[email protected]> Co-authored-by: Shi-Hao Hong <[email protected]> Co-authored-by: Darren Austin <[email protected]>

Address time picker design issues

3173a3a

flutter-dashboard bot added f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels. labels Aug 3, 2020

googlebot added the cla: yes label Aug 3, 2020

willlarche reviewed Aug 3, 2020

View reviewed changes

johnsonmh approved these changes Aug 3, 2020

View reviewed changes

rami-a requested a review from HansMuller August 3, 2020 20:09

Re-run checks

82bf177

HansMuller approved these changes Aug 3, 2020

View reviewed changes

rami-a added the waiting for tree to go green label Aug 3, 2020

fluttergithubbot removed the waiting for tree to go green label Aug 3, 2020

Update broken test

4879d3f

rami-a added the waiting for tree to go green label Aug 4, 2020

Ensure RTL behavior is correct

c1ed2c4

flutter-dashboard bot added the a: internationalization Supporting other languages or locales. (aka i18n) label Aug 4, 2020

rami-a mentioned this pull request Aug 4, 2020

TimePicker is not correct in RTL languages #62775

Closed

rami-a removed the waiting for tree to go green label Aug 4, 2020

rami-a requested a review from HansMuller August 4, 2020 14:09

HansMuller approved these changes Aug 4, 2020

View reviewed changes

Revert icon change for now

4e0c237

rami-a added the waiting for tree to go green label Aug 4, 2020

fluttergithubbot removed the waiting for tree to go green label Aug 4, 2020

Re-run checks

f94d999

rami-a added the waiting for tree to go green label Aug 4, 2020

fluttergithubbot merged commit f29f05e into flutter:master Aug 4, 2020

rami-a mentioned this pull request Aug 7, 2020

TimePicker not Localized #63165

Closed

rami-a deleted the time-picker-misc-fixes branch August 10, 2020 14:39

HansMuller added the cp: 1.20 label Aug 10, 2020

pcsosinski removed the cp: 1.20 label Aug 10, 2020

Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020

Address misc time picker design issues (flutter#62803)

ae15a7a

rami-a mentioned this pull request Aug 12, 2020

Wrong hour/minute order in timePicker in RTL mode #63427

Closed

pcsosinski pushed a commit to pcsosinski/flutter that referenced this pull request Aug 12, 2020

Address misc time picker design issues (flutter#62803)

f2445c5

rami-a mentioned this pull request Aug 12, 2020

Ensure time picker input mode lays out correctly in RTL #63599

Merged

13 tasks

mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020

Address misc time picker design issues (flutter#62803)

78eeac2

github-actions bot locked as resolved and limited conversation to collaborators Aug 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Address misc time picker design issues #62803

Address misc time picker design issues #62803

Uh oh!

rami-a commented Aug 3, 2020 •

edited

Loading

Uh oh!

willlarche left a comment

Uh oh!

willlarche Aug 3, 2020

Uh oh!

rami-a Aug 3, 2020

Uh oh!

willlarche Aug 3, 2020

Uh oh!

rami-a Aug 3, 2020

Uh oh!

HansMuller left a comment

Uh oh!

rami-a commented Aug 3, 2020

Uh oh!

fluttergithubbot commented Aug 3, 2020

Uh oh!

fluttergithubbot commented Aug 4, 2020

Uh oh!

pcsosinski commented Aug 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Address misc time picker design issues #62803

Address misc time picker design issues #62803

Uh oh!

Conversation

rami-a commented Aug 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Tests

Checklist

Breaking Change

Uh oh!

willlarche left a comment

Choose a reason for hiding this comment

Uh oh!

willlarche Aug 3, 2020

Choose a reason for hiding this comment

Uh oh!

rami-a Aug 3, 2020

Choose a reason for hiding this comment

Uh oh!

willlarche Aug 3, 2020

Choose a reason for hiding this comment

Uh oh!

rami-a Aug 3, 2020

Choose a reason for hiding this comment

Uh oh!

HansMuller left a comment

Choose a reason for hiding this comment

Uh oh!

rami-a commented Aug 3, 2020

Uh oh!

fluttergithubbot commented Aug 3, 2020

Uh oh!

fluttergithubbot commented Aug 4, 2020

Uh oh!

pcsosinski commented Aug 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

rami-a commented Aug 3, 2020 •

edited

Loading