Skip to content

move compile/target sdk versions to 29 #62799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluttergithubbot merged 1 commit into from
Aug 4, 2020
Merged

move compile/target sdk versions to 29 #62799

fluttergithubbot merged 1 commit into from
Aug 4, 2020

Conversation

@xster
Copy link
Member

@xster xster commented Aug 3, 2020 •
edited
Loading

Fixes #54382

(we already moved our engine builds to 29 last year)

@xster xster requested a review from jmagman August 3, 2020 18:23
@flutter-dashboard flutter-dashboard bot added a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) d: examples Sample code and demos c: contributor-productivity Team-specific productivity, code health, technical debt. tool Affects the "flutter" command-line tool. See also t: labels. labels Aug 3, 2020
jmagman
jmagman reviewed Aug 3, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xster This doesn't cause any new warnings in new projects, right?

@xster
Copy link
Member Author

xster commented Aug 3, 2020

oh wow, actually just checked. Android fancy now #54382 (comment)

jmagman
jmagman approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this doesn't cause any new warnings in new projects.
Similar to #26444 and #26790 and #26798

@xster
Copy link
Member Author

xster commented Aug 4, 2020

Ya, that's what I meant to say. It does not. It's a smooth transition as far as I can tell.

@fluttergithubbot fluttergithubbot merged commit 5b3dc52 into flutter:master Aug 4, 2020
jonahwilliams pushed a commit that referenced this pull request Aug 4, 2020
Revert "move compile/target sdk versions to 29 (#62799)"
5b65d43 
This reverts commit 5b3dc52.
@jonahwilliams jonahwilliams mentioned this pull request Aug 4, 2020
Merged
jonahwilliams pushed a commit that referenced this pull request Aug 4, 2020
Revert "move compile/target sdk versions to 29 (#62799)" (#62884)
e8ad863 
This reverts commit 5b3dc52.
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@xster @Pragya007
move compile/target sdk versions to 29 (flutter#62799)
fdf54b7
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@Pragya007
Revert "move compile/target sdk versions to 29 (flutter#62799)" (flut…
f6b8ac7 
…ter#62884)

This reverts commit 5b3dc52.
xster added a commit to xster/flutter that referenced this pull request Aug 11, 2020
@xster
move compile/target sdk versions to 29 (flutter#62799)
de5ef39
fluttergithubbot pushed a commit that referenced this pull request Aug 11, 2020
@xster
move compile/target sdk versions to 29 (#62799) (#63008)
df8e537
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@xster @mingwandroid
move compile/target sdk versions to 29 (flutter#62799)
63030fd
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@mingwandroid
Revert "move compile/target sdk versions to 29 (flutter#62799)" (flut…
5be4192 
…ter#62884)

This reverts commit 5b3dc52.
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@xster @mingwandroid
move compile/target sdk versions to 29 (flutter#62799) (flutter#63008)
d3d09e8
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jmagman jmagman jmagman approved these changes

Assignees

No one assigned

Labels

a: accessibility Accessibility, e.g. VoiceOver or TalkBack. (aka a11y) c: contributor-productivity Team-specific productivity, code health, technical debt. d: examples Sample code and demos tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Android SDK from 28 to 29 in new plugins and project templates

4 participants

@xster @jmagman @googlebot @fluttergithubbot