Fix SliverList scrollOffsetCorrection 0 case #62615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Piinks
added
c: regression
chunhtai
reviewed
Jul 30, 2020
chunhtai
reviewed
Aug 5, 2020
|
moving cp label to the issue (#62198) for discussion |
pcsosinski
pushed a commit
to pcsosinski/flutter
that referenced
this pull request
Aug 12, 2020
pcsosinski
pushed a commit
that referenced
this pull request
Aug 13, 2020
* Fix SliverList scrollOffsetCorrection 0 case (#62615) * Case insensitive check flavor names against Xcode schemes (#61140) * Address misc time picker design issues (#62803) * Update to the latest localizations (#63026) * Removed the inputFormatters from the text input fields used by the Date Pickers (#63461) * Fix App.framework path in Podfile (#63412) * Update engine hash to 1.20.2 Co-authored-by: Kate Lovett <[email protected]> Co-authored-by: Jenn Magder <[email protected]> Co-authored-by: Rami <[email protected]> Co-authored-by: Shi-Hao Hong <[email protected]> Co-authored-by: Darren Austin <[email protected]>
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes the offset correction in the performLayout of SliverList to account for 0. In the use cases where the calculated correction is 0, it crashes since SliverGeometry asserts the correction should never be 0. This opportunity presents itself more readily on iOS and Mac platforms due to over scroll.
Related Issues
Fixes #62198
Tests
Regression test for 0 scrollOffsetCorrection
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.