-
Notifications
You must be signed in to change notification settings - Fork 29.7k
[flutter_tools]Set plugin template min flutter sdk version to 1.20 #62605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flutter_tools]Set plugin template min flutter sdk version to 1.20 #62605
Conversation
jmagman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is what was agreed on, code LGTM!
| homepage: | ||
|
|
||
| environment: | ||
| sdk: ">=2.7.0 <3.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also change the sdk version, though it doesn't matter too much since it's shipped with Flutter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to do that, it would become >=2.9.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any risk of that but since we are cherry picking this, let's make it as simple as possible. We can always update the sdk version later. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a preference.
Description
Setting the min flutter sdk version to 1.20.0
After 1.20.0, newly created plugins won't contain no-op iOS folders. Which requires the sdk version to be 1.20.0 or above.
WARNING
Landing this PR before 1.20 release will have below impacts:
Related Issues
#60215
Tests
I added the following tests:
newly created plugin has min flutter sdk version as 1.20.0
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.