Skip to content

Conversation

@cyanglaz
Copy link
Contributor

@cyanglaz cyanglaz commented Jul 30, 2020

Description

Setting the min flutter sdk version to 1.20.0
After 1.20.0, newly created plugins won't contain no-op iOS folders. Which requires the sdk version to be 1.20.0 or above.

WARNING
Landing this PR before 1.20 release will have below impacts:

  • For people who is on stable (1.17)
    • Plugin author will be fine to create new plugins, the plugin won't have 1.20.0 constraints.
    • App authors will not be able to use plugins that are newly created by people who are on master. They will see an error about version solving failed.
  • For people who is on beta (1.20.0-7.X.pre)
    • Plugin author will be fine to create new plugins, the plugin won't have 1.20.0 constraints.
    • App authors will not be able to use plugins that are newly created by people who are on master. They will see an error about version solving failed.
  • For people who is on master
    • Plugin author will be fine to create new plugins.
    • App authors will be fine to use the newly created plugins.

Related Issues

#60215

Tests

I added the following tests:

newly created plugin has min flutter sdk version as 1.20.0

Checklist

Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I signed the CLA.
  • I read and followed the Flutter Style Guide, including Features we expect every widget to implement.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read Handling breaking changes.

@fluttergithubbot fluttergithubbot added the tool Affects the "flutter" command-line tool. See also t: labels. label Jul 30, 2020
@cyanglaz cyanglaz changed the title Set plugin template min flutter sdk version to 1.20 [flutter_tools]Set plugin template min flutter sdk version to 1.20 Jul 30, 2020
Copy link
Member

@jmagman jmagman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is what was agreed on, code LGTM!

homepage:

environment:
sdk: ">=2.7.0 <3.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also change the sdk version, though it doesn't matter too much since it's shipped with Flutter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to do that, it would become >=2.9.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any risk of that but since we are cherry picking this, let's make it as simple as possible. We can always update the sdk version later. WDYT?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a preference.

@cyanglaz
Copy link
Contributor Author

cc @pcsosinski @csells

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tool Affects the "flutter" command-line tool. See also t: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants