After cleaning up 812 warnings: Make warnings fatal in dartdocs #62553
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fluttergithubbot
added
c: contributor-productivity
goderbauer
force-pushed
the
enforceDartDoc
branch
from
80637ac to
8fa461b
Compare
goderbauer
changed the title
goderbauer
force-pushed
the
enforceDartDoc
branch
from
8fa461b to
6cb1c65
Compare
Contributor
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
goderbauer
added
framework
Piinks
approved these changes
Jul 30, 2020
| - unknown-file | ||
| - missing-from-search-index | ||
| - unresolved-doc-reference | ||
| - orphaned-file |
Contributor
There was a problem hiding this comment.
über nit: It appears these are organized alphabetically except for this one. 🤓
Member
Author
There was a problem hiding this comment.
🤦 I will fix this in a follow-up PR (I want to submit this ASAP to avoid new warnings from sneaking in and pushing another commit would restart all the bots...)
tvolkert
approved these changes
Jul 30, 2020
Contributor
tvolkert
left a comment
tvolkert
left a comment
There was a problem hiding this comment.
I wish I had more than 1 LGTM to give.
Pragya007
pushed a commit
to Pragya007/flutter
that referenced
this pull request
Aug 11, 2020
mingwandroid
pushed a commit
to mingwandroid/flutter
that referenced
this pull request
Sep 6, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Ensures that our dartdocs are free of warning and errors by failing the dartdoc check when any error/warning is present. All existing 812 warnings in our docs have been cleaned up.
Related Issues
Fixes #31931
Tests
I added the following tests:
n/a
Checklist
Before you create this PR, confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.