Skip to content

Fix Border.symmetric: phase 3 - #62471

Merged
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:border
Jul 29, 2020
Merged

tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:border

Conversation

@tvolkert

Copy link
Copy Markdown
Contributor

Description

This removes the (now unused) invertMeaningOfVerticalAndHorizontal flag.

Related Issues

Fixes #61470

Tests

  • I updated the affected test

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

This removes the (now unused) `invertMeaningOfVerticalAndHorizontal`
flag.

#61470
@tvolkert tvolkert added the framework flutter/packages/flutter repository. See also f: labels. label Jul 29, 2020
@tvolkert
tvolkert requested a review from goderbauer July 29, 2020 06:48

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
tvolkert merged commit da62b6d into flutter:master Jul 29, 2020
@tvolkert
tvolkert deleted the border branch July 29, 2020 17:20
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
This removes the (now unused) `invertMeaningOfVerticalAndHorizontal`
flag.

Fixes flutter#61470
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
This removes the (now unused) `invertMeaningOfVerticalAndHorizontal`
flag.

Fixes flutter#61470
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Border.symmetric constructor inverts the meaning of vertical and horizontal

3 participants