Skip to content

Conversation

@justinmc
Copy link
Contributor

@justinmc justinmc commented Jul 18, 2020

Description

Uses the iOS hasStrings method that's being added in the engine in flutter/engine#19859 to avoid iOS's clipboard notification.

Related Issues

Closes #60145
Depends on flutter/engine#19859
Depends on flutter/engine#20393
Depends on flutter/engine#20531
Depends on flutter/engine#21388 and more to come for other platforms

Tests

I added the following tests:

TODO

Breaking Change

None

@justinmc justinmc self-assigned this Jul 18, 2020
@fluttergithubbot
Copy link
Contributor

It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat.

Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing.

@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 18, 2020
@justinmc justinmc marked this pull request as draft July 18, 2020 01:05
@Piinks Piinks added platform-ios iOS applications specifically a: text input Entering text in a text field or keyboard related problems work in progress; do not review labels Jul 21, 2020
@goderbauer
Copy link
Member

PR triage: Looks like the engine side was submitted. Is this ready?

@justinmc
Copy link
Contributor Author

No, I need to add hasStrings to all the other platforms in addition to iOS. I have an Android PR at flutter/engine#20393 and will follow up with the others. I've added this to the description.

@justinmc justinmc added this to the 1.23 - September 2020 milestone Aug 12, 2020
@flutter-dashboard
Copy link

This pull request has been changed to a draft. The currently pending flutter-gold status will not be able to resolve until a new commit is pushed or the change is marked ready for review again.

@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@Piinks
Copy link
Contributor

Piinks commented Sep 2, 2020

Bad bot. :)

@justinmc
Copy link
Contributor Author

justinmc commented Sep 3, 2020

This PR is hanging around for awhile while I finish all the engine dependencies, I'm probably confusing the bot.

@flutter-dashboard
Copy link

This pull request has not been updated in a while. Please update this pull request to receive results from Gold, or close it.

@Hixie Hixie modified the milestones: 1.23 - September 2020, Overdue Oct 6, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • Please get at least one approved review before re-applying this label. Reviewers: If you left a comment approving, please use the "approve" review action instead.
  • The status or check suite Linux analyze has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Linux framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Mac framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite Windows framework_tests has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite analyze-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-widgets-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite framework_tests-libraries-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-linux has failed. Please fix the issues identified (or deflake) before re-applying this label.
  • The status or check suite deploy_gallery-macos has failed. Please fix the issues identified (or deflake) before re-applying this label.

@goderbauer
Copy link
Member

PR triage update from @justinmc: "I need to do a PR for Windows and a PR for Fuchsia."

@Hixie Hixie removed this from the Overdue milestone Dec 10, 2020
@justinmc
Copy link
Contributor Author

Closing this for now until I have time to work on Windows and Fuchsia engine methods, at which point I'll reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

a: text input Entering text in a text field or keyboard related problems framework flutter/packages/flutter repository. See also f: labels. platform-ios iOS applications specifically

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unsolicited iOS14 clipboard permission prompt

6 participants