Skip to content

Fix Border.symmetric: phase 2 - #61666

Merged
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:border_symmetric
Jul 17, 2020
Merged

Fix Border.symmetric: phase 2#61666
tvolkert merged 1 commit into
flutter:masterfrom
tvolkert:border_symmetric

Conversation

@tvolkert

@tvolkert tvolkert commented Jul 16, 2020

Copy link
Copy Markdown
Contributor

Description

This updates the default value of the invertMeaningOfVerticalAndHorizontal
argument from true to false.

Related Issues

#61470

Tests

I updated the relevant tests.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@tvolkert
Fix Border.symmetric: phase 2
a9bbbb3 
This updates the default value of the `invertMeaningOfVerticalAndHorizontal`
argument from true to false.

#61470
@tvolkert
tvolkert requested a review from goderbauer July 16, 2020 22:29
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 16, 2020
goderbauer
goderbauer approved these changes Jul 16, 2020
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tvolkert
tvolkert merged commit 7ea710c into flutter:master Jul 17, 2020
@tvolkert
tvolkert deleted the border_symmetric branch July 17, 2020 06:14
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@tvolkert @Pragya007
Fix Border.symmetric: phase 2 (flutter#61666)
717b2da 
This updates the default value of the `invertMeaningOfVerticalAndHorizontal`
argument from true to false.

flutter#61470
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@tvolkert @mingwandroid
Fix Border.symmetric: phase 2 (flutter#61666)
b61fffb 
This updates the default value of the `invertMeaningOfVerticalAndHorizontal`
argument from true to false.

flutter#61470
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvolkert @goderbauer @googlebot @fluttergithubbot