Skip to content

Fix Border.symmetric: phase 1 - #61474

Merged
fluttergithubbot merged 1 commit into
flutter:masterfrom
tvolkert:border_side_symmetric
Jul 14, 2020
Merged

Fix Border.symmetric: phase 1#61474
fluttergithubbot merged 1 commit into
flutter:masterfrom
tvolkert:border_side_symmetric

Conversation

@tvolkert

@tvolkert tvolkert commented Jul 14, 2020

Copy link
Copy Markdown
Contributor

Description

This adds a invertMeaningOfVerticalAndHorizontal argument to the
Border.symmetric constructor, which will allow us to fix the semantics
of the vertical and horizontal arguments in a soft-breaking way.

Related Issues

#61470

Tests

I added the following tests:

  • A test that when the argument is overridden, you get the correct behavior in the constructor.

Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I signed the [CLA].
  • I read and followed the [Flutter Style Guide], including [Features we expect every widget to implement].
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I updated/added relevant documentation (doc comments with ///).
  • All existing and new tests are passing.
  • The analyzer (flutter analyze --flutter-repo) does not report any problems on my PR.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Did any tests fail when you ran them? Please read [Handling breaking changes].

  • No, no existing tests failed, so this is not a breaking change.
  • Yes, this is a breaking change. If not, delete the remainder of this section.

@tvolkert
Fix Border.symmetric: phase 1
c04744c 
This adds a `invertMeaningOfVerticalAndHorizontal` argument to the
Border.symmetric constructor, which will allow us to fix the semantics
of the `vertical` and `horizontal` arguments in a soft-breaking way.

#61470
@tvolkert
tvolkert requested a review from goderbauer July 14, 2020 19:22
@fluttergithubbot fluttergithubbot added the framework flutter/packages/flutter repository. See also f: labels. label Jul 14, 2020
@tvolkert

tvolkert commented Jul 14, 2020

Copy link
Copy Markdown
Contributor Author

FYI @KagurazakaHanabi

goderbauer
goderbauer approved these changes Jul 14, 2020
View reviewed changes

@goderbauer goderbauer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I cross-checked with https://en.wikipedia.org/wiki/Vertical_and_horizontal this time and it looks right :P

@fluttergithubbot
fluttergithubbot merged commit 4195ad4 into flutter:master Jul 14, 2020
@tvolkert
tvolkert deleted the border_side_symmetric branch July 14, 2020 20:21
Pragya007 pushed a commit to Pragya007/flutter that referenced this pull request Aug 11, 2020
@tvolkert @Pragya007
Fix Border.symmetric: phase 1 (flutter#61474)
15e7beb
mingwandroid pushed a commit to mingwandroid/flutter that referenced this pull request Sep 6, 2020
@tvolkert @mingwandroid
Fix Border.symmetric: phase 1 (flutter#61474)
73aa17e
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees

No one assigned

Labels

framework flutter/packages/flutter repository. See also f: labels.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tvolkert @goderbauer @googlebot @fluttergithubbot