Document the mapping of system mouse cursors on Windows and Linux #61399
Conversation
fluttergithubbot
added
the
framework
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
dkwingsmt
added
a: mouse
| /// The cursor names are chosen to reflect the cursors' use cases instead of | ||
| /// their shapes, because different platforms might (although not commonly) use | ||
| /// different shapes for the same use case. | ||
| /// The cursor names are based on the cursors' use cases instead of their shapes. |
There was a problem hiding this comment.
The previous explanation seemed more complete to me, because it explained why.
| /// * Windows: IDC_WAIT | ||
| /// * Web: wait | ||
| /// * Linux: wait | ||
| /// |
There was a problem hiding this comment.
Can you also add "macOS: [not available]" (and iOS) or something, so that it's clear that it isn't available on macOS/iOS? Or at least a statement that it isn't supported on systems that aren't listed. What happens if I specify SystemMouseCursor.wait on a system that doesn't support it?
There was a problem hiding this comment.
I added the following comment
/// If the platform that the application is running on is not listed for a cursor,
/// using this cursor falls back to [basic].
(Thought I did, thanks for pointing out).
…ursors-windows-linux
|
This pull request is not suitable for automatic merging in its current state.
|
…utter#61399) Add document for mouse cursor mapping on Windows and Linux.
…utter#61399) Add document for mouse cursor mapping on Windows and Linux.
4 participants
Description
This PR documents how system mouse cursors are mapped to platform values on Windows (Win32) and Linux (GTK), officially supporting them.
Almost all native cursors are mapped to as many Flutter cursors as possible.
IDC_UPARROW. For the reason, see [Windows] Add mouse cursor "vertical arrow" IDC_UPARROW and other missing cursors #61397.Related Issues
Tests
I added the following tests:
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze --flutter-repo) does not report any problems on my PR.Breaking Change
Did any tests fail when you ran them? Please read Handling breaking changes.